Tom Pike
Tom Pike
@ankitk50 I piled on to @rlskoeser comments, if you could address those then we could merge, in general I would emphasize, please add docstrings and comments to make the code...
@Corvince I had a very long explanation, but as I am digging in I am finding inconsistencies in my understanding, so I will need to dig into this some more....
I just went back thru and actually found another change in Mesa 2.0 that broke the tutorial I need to go back in and fix. So i will try and...
> @tpike3 I can confirm that batch run leads to excessive memory usage, although it doesn't actually start that many model runs. I need to investigate this further but my...
Thanks @EwoutH this is a great proposal. I am good with this, to me @EwoutH covered my concerns which is backwards compatible and easy to understand for users. I know...
Will do...I will set up the next dec session discussion this weekend and do the notes form last time (apologies I got sidetracked by NUMFOCUS and other newsletter)
@EwoutH Do we want to wait for speed on this one or merge it and do a 2.3.1 to fix the bug?
> @haleelsada would you be able to write the unittests? @EwoutH Thanks for keeping up with this!
@NirobNabil Just curious, did you try this change with `batch_run`? I don't think it will matter, but multi-processing can make things interesting. Thanks for the PR!
To be clear on the process: 1 - Separate PR that has a deprecation warning. 2 - Merge this in 3.0 I would agree that we want to remove the...