science-gothic icon indicating copy to clipboard operation
science-gothic copied to clipboard

Fontbakery does not like year range in copyright notice

Open tphinney opened this issue 1 year ago • 2 comments

[1;36;40mcom.google.fonts/check/font_copyright[0m [0;35;40mCopyright notices match canonical pattern in fonts[0m with ScienceGothic[YOPQ,slnt,wdth,wght].ttf

[1;96;100mMore info:[0m https://github.com/googlefonts/fontbakery/pull/2383


 [0;31;40mFAIL[0m Name Table entry: Copyright notices should match a                    
      pattern similar to: "Copyright 2019 The Familyname Project Authors    
      (git url)" But instead we have got: "Copyright 2019-2022 The Science  
      Gothic Project Authors.                                               
      https://github.com/tphinney/science-gothic/blob/main/AUTHORS.txt"     
      [code: bad-notice-format]                                             


Result: [0;31;40mFAIL[0m

tphinney avatar Dec 10 '23 04:12 tphinney

This seems like an error in Fontbakery. For a font in development for more than a year, I expect it could have multiple years in the copyright notice. One sees such copyright notices all the time. Fontbakery should accept any mix of single years and year ranges. For example this should be considered valid:

"Copyright 2017-19, 2021, 2022-24 The Familyname Project Authors (git url)"

tphinney avatar Dec 10 '23 04:12 tphinney

I filed an issue against Fontbakery at the time: https://github.com/fonttools/fontbakery/issues/4386

Seems like it may be loosened so as to be a WARN rather than a FAIL, which would be good enough for me.

tphinney avatar Jan 08 '24 20:01 tphinney