gnome-stats-pro icon indicating copy to clipboard operation
gnome-stats-pro copied to clipboard

Fix compatibility with Gnome 3.38

Open Williangalvani opened this issue 4 years ago • 8 comments

I'm not sure if this breaks compatibility with earlier versions, but this fixes 3.38: image

I'm also not sure about the x_fill and y_fill properties, they are apparently gone (causing error when used) and I can't find recent documentation of StBin. They didn't seem to matter, though.

fix #25 fix #26

Williangalvani avatar Oct 09 '20 16:10 Williangalvani

thanks, for the contribution solved the problem of unavailability with gnome-shell version 3.38

MichaelDeMattos avatar Oct 13 '20 11:10 MichaelDeMattos

how can i build the extension and use this fork?

FarisZR avatar Oct 30 '20 12:10 FarisZR

how can i build the extension and use this fork?

something like this (haven't tested, but just get my files and overwrite the current ones):

git clone https://github.com/Williangalvani/gnome-stats-pro.git
git checkout 3.38
git submodule update --init --recursive
cp -r gnome-stats-pro/* ~/.local/share/gnome-shell/extensions/[email protected]/

You need to put the files in ~/.local/share/gnome-shell/extensions/[email protected]/

Williangalvani avatar Oct 30 '20 13:10 Williangalvani

@Williangalvani I have made it work without removing tweener. Happens that the import path now should be refered as imports.tweener.tweener instead of imports.ui.tweener.

Also, about the properties x_fill and y_fill may you replace them with x_expand and y_expand, respectively.

bbermann avatar Nov 07 '20 21:11 bbermann

I believe that tweener is being dropped from Gnome as a whole: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1200

Williangalvani avatar Nov 07 '20 21:11 Williangalvani

Did anyone test this fix with Gnome 40.x ?

eisraeli avatar Nov 09 '21 10:11 eisraeli

Did anyone test this fix with Gnome 40.x ?

it

Did anyone test this fix with Gnome 40.x ?

Yes, I used this branch on 40 and I'm now using it on 41

Williangalvani avatar Nov 18 '21 15:11 Williangalvani

@Williangalvani It doesn't seem like this repo is still being maintained.... that's a shame.

eisraeli avatar Nov 30 '21 07:11 eisraeli