pythonocc-core icon indicating copy to clipboard operation
pythonocc-core copied to clipboard

update to occt7.6

Open looooo opened this issue 2 years ago • 5 comments

@tpaviot any plans to update to occt7.6. For conda-forge occt7.6 migration there is only IfcOpenShell and pythonocc missing. Would be nice to move the full CAD-environment to occt7.6.

looooo avatar May 27 '22 11:05 looooo

I started here. Has someone information about TCollection? This header are (re)moved:

  • TCollection_BaseSequence.hxx
  • TCollection_BasicMap.hxx
  • TCollection_BasicMapIterator.hxx
  • TCollection_MapNode.hxx
  • TCollection_MapNodePtr.hxx
  • TCollection_SeqNode.hxx
  • TCollection_SeqNodePtr.hxx
  • TCollection_Side.hxx

I try to use my eyes. But I have not found in "Upgrade from older OCCT versions" a hint.

ageeye avatar Jun 19 '22 10:06 ageeye

@ageeye, these TCollection header files are remnants of WOK template generation, which have been dropped in OCCT 7.0.0 in favor of C++ templates from NCollection. In the current form they are unusable for anything but legacy collections declared in CDL at application level - which is, I believe, not the case of this project.

TColStd_PackedMapOfInteger was the only class in OCCT itself that used legacy base class TCollection_BasicMap, which has been fixed in OCCT 7.6.0.

So what you need to do is just to remove inclusion of these header files.

gkv311 avatar Jun 20 '22 21:06 gkv311

@gkv311 Thank you for your fast answer. That sounds good. After work I will test it.

ageeye avatar Jun 21 '22 04:06 ageeye

It works. But if one issue is solved, two new problems are born.

ageeye avatar Jun 21 '22 15:06 ageeye

FWIW a while back I also experimented with moving pythonocc-core to v7.6 by modifying the pythonocc-generator that updates the src directory in https://github.com/Krande/pythonocc-core/tree/v7.6.2a1. See issue tracker -> https://github.com/tpaviot/pythonocc-generator/issues/84

I also set up a github actions pipeline to automatically compile pythonocc-core on each push for win, linux and osx (latest attempt -> https://github.com/Krande/pythonocc-core/actions/runs/2813016527). I haven't been successfully in my attempts yet. But maybe if we combine our efforts we might be able to update pythonocc-core to support v7.6?

Krande avatar Aug 07 '22 12:08 Krande

@looooo wrapper has been updated to occt-7.6.2, the pythonocc-demos updated. Release 7.6.2 tagged and ready to be deployed at conda-forge

tpaviot avatar Aug 17 '22 13:08 tpaviot

thanks, https://github.com/conda-forge/pythonocc-core-feedstock/pull/14

looooo avatar Aug 17 '22 16:08 looooo

@looooo that's great, thank you, this issue can be closed

tpaviot avatar Aug 23 '22 03:08 tpaviot