ContinuousTransformations.jl icon indicating copy to clipboard operation
ContinuousTransformations.jl copied to clipboard

TransformLogLikelihood terminology

Open simonbyrne opened this issue 7 years ago • 1 comments

Thanks for the package! It has a lot of really neat features.

My one nitpick is that TransformLogLikelihood is not really that accurate of a name. As I understand it, it accounts for the Jacobian term when doing the change-of-variables. But the Jacobian term is due to the fact that it's a density; likelihoods by themselves are parametrisation invariant (e.g. maximum likelihood estimates won't change).

I would suggest TransformLogDensity (since you don't need a likelihood at all, e.g. you could just be sampling from an arbitrary distribution).

simonbyrne avatar Jun 28 '18 21:06 simonbyrne

Good point. I am working on a new package that will replace this one, so I opened an issue there. https://github.com/tpapp/TransformVariables.jl/issues/1

tpapp avatar Jun 29 '18 05:06 tpapp