Thomas Padioleau
Thomas Padioleau
https://github.com/kokkos/kokkos/issues/1950
In some situations it can be useful to reinterpret the support of a `ChunkSpan`: ``` ChunkSpan chk; DiscreteDomain dom; ChunkSpan reinterpreted_chk(chk.data_handle(), dom); ``` This way is unsafe because the constructor...
With the recent possibility for mdspan to choose the `index_type`, I think we should a signed integer type common for `DiscreteElementType`, `std::extents` and iterators difference_type that is to say `std::ptrdiff_t`.
> I can merge but what would be the remaining issue ? The issue was about dangling pointers and this seems to fix it ? We may have one remaining...
I suggest that we try an implementation of the `for_each` algorithm independent of the `DiscreteDomain` and `DiscreteVector` classes. I would prefer an implementation that should work for any class that...
As for now, discrete dimensions are represented by the discrete spaces themselves. For example this forces the definition of two classes to differentiate nodes from cells in a 1d mesh....
This is a separate issue, but we should really align the constructors and assignment operators _Originally posted by @jbigot in https://github.com/CExA-project/ddc/issues/210#issuecomment-1781008555_