hapi-authorization icon indicating copy to clipboard operation
hapi-authorization copied to clipboard

Published 20 hours ago • verified publisher icon toymachiner62

Fix bonded config

Open g-div opened this issue 6 years ago • 4 comments

Removing the arrow function definition, the bonded config can be easily accessed as before (this.config).

Close #26

g-div avatar Feb 12 '19 10:02 g-div

Coverage Status

Coverage remained the same at 100.0% when pulling a1dd791a1fe5eca5180fdc54d5f855b92fbdf6d3 on g-div:fix-settings into 8dac9750970f904b3d594857a6c1afc0bfb3c9f0 on toymachiner62:master.

coveralls avatar Feb 12 '19 10:02 coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling a1dd791a1fe5eca5180fdc54d5f855b92fbdf6d3 on g-div:fix-settings into 8dac9750970f904b3d594857a6c1afc0bfb3c9f0 on toymachiner62:master.

coveralls avatar Feb 12 '19 10:02 coveralls

The build failed with this change. You'll need to also fix the unit tests.

toymachiner62 avatar Feb 19 '19 17:02 toymachiner62

I know, I've tried but I didn't understand a couple of things:

  1. The failing test seems to be included twice: here and here

  2. The test is failing because the user role isn't defined in the role hierarchy and this seems to be an expected behaviour. So it seems to me that the test was expecting something which should not be allowed by the plugin.

Should I just delete both tests ?

g-div avatar Feb 20 '19 10:02 g-div