hapi-authorization icon indicating copy to clipboard operation
hapi-authorization copied to clipboard

hierarchy and rolehierarchy doesnt seems to be working in hapi v17

Open tk120404 opened this issue 6 years ago • 7 comments

In hapi v17, config are not getting bonded with settings

  server.bind({
    config: settings
  });

Due to which this.config.hierarchy is always coming as false

tk120404 avatar Nov 12 '18 07:11 tk120404

@toymachiner62 i did a PR. It fail in 2 tests. I've add some comments to the pr about those TC, could you take a look ?

aquelatecnologia avatar Sep 23 '19 15:09 aquelatecnologia

I was about to report the same issue, @aquelatecnologia sent a pr to your repo to fix the failing test

RicardoRdzG avatar Oct 28 '19 23:10 RicardoRdzG

@toymachiner62 it's been almost 2 years since this bug has been reported. There is a PR that awaits your reply to fix this bug. It's quite a blocker for us, given that we can no longer use roles hierarchy.

emanuelecasadio avatar Apr 23 '21 08:04 emanuelecasadio

@toymachiner62 it's been almost 2 years since this bug has been reported. There is a PR that awaits your reply to fix this bug. It's quite a blocker for us, given that we can no longer use roles hierarchy.

I honestly haven't used hapi.js in about 5-6 years. If someone wants to take over this repo i'm more than happy to let them as I don't have ample time to dedicate to this repo anymore.

toymachiner62 avatar Apr 26 '21 15:04 toymachiner62

What needs to be done? I can do code reviews and maintenance. But I am no longer working with hapi either.

RicardoRdzG avatar Apr 26 '21 17:04 RicardoRdzG

What needs to be done? I can do code reviews and maintenance. But I am no longer working with hapi either.

You're not working with hapi but it's a blocker for you?

toymachiner62 avatar Apr 26 '21 19:04 toymachiner62

It was back in october 2019, but as anybody with access to source rolled my own version with the fix.

RicardoRdzG avatar Apr 28 '21 15:04 RicardoRdzG