tox icon indicating copy to clipboard operation
tox copied to clipboard

Attempt to recreate broken environments

Open ssbarnea opened this issue 2 years ago • 3 comments

This bug was observed when machine was upgraded from one architecture to another (x64-aarm64) or when running on network shares.

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • [ ] wrote descriptive pull request text
  • [ ] added/updated test(s)
  • [ ] updated/extended the documentation
  • [ ] added relevant issue keyword in message body
  • [ ] added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
      
    • also see examples
  • [ ] added yourself to CONTRIBUTORS (preserving alphabetical order)

ssbarnea avatar May 19 '22 08:05 ssbarnea

I was inclined to catch any exception and attempt to recreate....

ssbarnea avatar May 19 '22 12:05 ssbarnea

@gaborbernat I can probably find a way to simulate the same kind of error with a test but I do not want to spend an entire day writing such a test just to be later told you do not want to merge the fix.

I really want to improve the UX for tox, so I will do it, but can you at least confirm that you also want to find a way to trigger recreate on broken environments? If we agree on that, we should be able to find a suitable implementation.

I am sure that envs can break in more than one way, but all we can do is to implement fixes gradually while we detect such cases.

ssbarnea avatar May 20 '22 07:05 ssbarnea

Sounds good :+1:

gaborbernat avatar May 20 '22 08:05 gaborbernat

Closing due to lack of progress.

gaborbernat avatar Aug 21 '22 18:08 gaborbernat

No offense taken, I got busy with more pressing issues. Speaking about progress, how is going with rewrite branch? 🤭

ssbarnea avatar Aug 21 '22 20:08 ssbarnea

how is going with rewrite branch

No promises :blush: lately been hindered with some health problems, so :shrug: eventually we'll get there I hope.

gaborbernat avatar Aug 21 '22 20:08 gaborbernat