pipdeptree icon indicating copy to clipboard operation
pipdeptree copied to clipboard

PR for issue #99 and issue #100

Open zufuliu opened this issue 6 years ago • 3 comments

PR for issue #99 and issue #100.

zufuliu avatar May 14 '18 10:05 zufuliu

First of all, sorry for a very late reply! Finally got around to looking at the PRs on this project.

Regarding #99 : I think just making the pkg.key lowercase will not solve the problem because the dump_graphviz function is using project_name attribute to identify graph nodes instead of key. I think a simple fix is to use key as the id for the graph node in the dump_graphviz function. It's also a "safer" solution as it won't affect rest of the code at all.

Regarding #100 : Looks good to me.

naiquevin avatar Jul 14 '19 12:07 naiquevin

Also, don't worry about the tests. I'm working on fixing the tests in another branch. In the meanwhile, I'll manually make sure that the tests pass before merging the PR.

naiquevin avatar Jul 14 '19 12:07 naiquevin

OK, I will make rebase the code and make separate PRs later.

zufuliu avatar Jul 14 '19 14:07 zufuliu

Closing as this seems to have stalled.

gaborbernat avatar Sep 04 '22 22:09 gaborbernat