clappr-youtube-playback icon indicating copy to clipboard operation
clappr-youtube-playback copied to clipboard

Fullscreen playback is broken

Open prabhu opened this issue 8 years ago • 4 comments

Its not resizing to full screen :(

prabhu avatar Aug 19 '16 00:08 prabhu

I have wasted too much time on this? Are you planning to take a look?

prabhu avatar Aug 24 '16 12:08 prabhu

https://github.com/towerz/clappr-youtube-playback/pull/11

tobilen avatar Nov 04 '16 21:11 tobilen

Same here, fullscreen broken

onigetoc avatar Feb 20 '17 23:02 onigetoc

I don't think we need resize event because we only need to set size of parent iframe div to 100% to follow player size, here what i'm talking:

<div player-wrapper>
    <div data-player="" style="height: 360px; width: 640px;"> // player size
         <div class="clappr-youtube-playback"> // resize here to 100% to follow size above
            <iframe src"..youtube.."> // youtube already set size to 100%

and for quick fix, replace:

this.player = new YT.Player('yt' + this.cid, {
    videoId: this.options.src,
    playerVars: playerVars,
    events: {

with:

this.player = new YT.Player('yt' + this.cid, {
    videoId: this.options.src,
    playerVars: playerVars,
    width: '100%', 
    height: '100%',
    events: {

ewwink avatar May 10 '17 06:05 ewwink