tower-grpc icon indicating copy to clipboard operation
tower-grpc copied to clipboard

UPDATE: Update the dependency(branch) of the h2 and typer

Open UkonnRa opened this issue 6 years ago • 5 comments

--- Update ---

For these issues, https://github.com/rust-lang-nursery/futures-rs/issues/1776 and https://github.com/rust-lang-nursery/futures-rs/issues/1090, maybe it's better to impl Stream<Item = Result<T, E>> rather than TryStream, so as TryFuture.

--- Original --- However, this branch is still not working, for:

107 | impl<T: Unpin> TryStream for Once<T> {
    |                ^^^^^^^^^ the trait `futures_core::stream::Stream` is not implemented for `generic::server::unary::Once<T>`
    |
    = note: required because of the requirements on the impl of `futures_core::stream::private_try_stream::Sealed` for `generic::server::unary::Once<T>`

UkonnRa avatar Sep 25 '19 13:09 UkonnRa

@UkonnRa the std-future branch is currently very far behind and in a stale state right now. I would recommend waiting a week or so and well have something that will make this all much easier to interact with std::future::Future.

LucioFranco avatar Sep 25 '19 14:09 LucioFranco

So could I access the latest branch of tower-rs with the latest rs-futures 0.3? I mean, I found that std-future branch is already the latest branch.

UkonnRa avatar Sep 25 '19 14:09 UkonnRa

@UkonnRa so tower has a 0.3.x branch for 0.3 futures. tower-grpc currently has not been updated as we have focused on updating the rest of the stack. But we will have something very shortly for this. So I would wait to use tower-grpc and std future for now. The std-future branch here was a test to see if we could upgrade tower-grpc and we ran into a few issues. But it is our top priority right now.

LucioFranco avatar Sep 25 '19 14:09 LucioFranco

OK I get it, so tower-grpc is blocked by tower, tower-grpc will be updated after the tower side work is finished. That's fair~

One more thing, now tower is almost no doc/guide at all. I cannot even understand the difference among tower, hyper and tokio....

UkonnRa avatar Sep 25 '19 14:09 UkonnRa

@UkonnRa I will give an update to this repo, probably the readme and an issue once we have the new stuff out. Thanks for the patience <3

LucioFranco avatar Sep 25 '19 14:09 LucioFranco