Jesse A. Tov

The idea of `set_bits` is that it works a block at a time, but doesn‘t necessarily set every bit in the block to the same value. Assuming that `n` is...

Thanks for the PR! I have two thoughts/questions: - Is an iterator over bits actually useful? I mean, I doubt it's needed often, and it's easy enough to do this:...

Okay, if you needed it then it must be at least a bit useful, and I don't think we'd be increasing API complexity significantly anyway. Do you want to implement...

I switched from 1.20.0 to 1.24.0 because it depended something that depended on lazy_static, and it didn't seem worth fighting that. As for the issue of returning `BitsIter` are you...

> Base builds with 4.10 on my machine? It's failing in CI with an error about not understanding FLAMBDA-style inline annotations.

You can see it here: https://github.com/tov/base/runs/7525879032?check_suite_focus=true

> These are only warnings. Could you use `dune build --release` instead? (or simply opam) They are warnings, but in dev mode the warnings are fatal. Shouldn't people be able...

I think there are two different issues: [src/float.ml]: https://github.com/janestreet/base/blob/cbd2d63e1c3c366929d567dae3285de3ed846553/src/float.ml#L490 [src/monad.ml]: https://github.com/tov/base/blob/6f088ddbe5a84682e21b1751c901c4348d9ff7b2/src/monad.ml#L200-L201 1. Warning 55 on all relevant OCaml versions (4.10 and later) that `round_nearest` cannot be inlined in [src/float.ml]: ```...

> As an aside, I'm suspicious at the 0s taken to build base in https://github.com/tov/base/runs/7525878932?check_suite_focus=true ? I see 1s to build and 0s to test. My machine agrees on 0s...

I've confirmed (with `dune --verbose`) that the fast builds are because of caching. And I've created a draft PR #138 in which CI builds with `--profile=release` on specified OCaml versions.