César Vargas Casaseca
César Vargas Casaseca
It also looks similar to [this crash](https://sentry.io/organizations/a8c/issues/3707324888/?project=1458804)
@itsmeichigo - Thanks for pointing this out! Indeed, if the feature is not released we **cannot** remove this flag **yet** 👍
Hi @joshheald! I try to reproduce this one and I couldn't. As I see, we have this flow: With one reader connected: `PaymentMethodsViewModel` -> `CardPresentPaymentsOnboardingPresenting` `CardPresentPaymentsOnboardingPresenting` -> `CardPresentPaymentsReadinessUseCase` `CardPresentPaymentsReadinessUseCase.checkCardPaymentReadiness` returns...
@malinajirka Is this issue done? Can we close it? :)
@iamgabrielma nice one, more than 60 lines of code and we avoid duplicated code 👏 I left some non-blocking remarks in the code, let me know what you think. :shipit:
@bozidarsevo We use the struct [Notice](https://github.com/woocommerce/woocommerce-ios/blob/f810789a9b3efbde3e4c00132aad44ba07dbc673/WooCommerce/Classes/Tools/Notices/Notice.swift#L8) with "Undo" as action title. See [here](https://github.com/woocommerce/woocommerce-ios/blob/f810789a9b3efbde3e4c00132aad44ba07dbc673/WooCommerce/Classes/ViewRelated/Orders/Order%20Details/OrderDetailsViewController.swift#L815) for an example.
> Would it maybe have more sense to show confirmation alert instead of showing undo option once it is removed? That's a good question. We usually use the Undo option...
@aehlke Thanks for the ping here! I added you as collaborator, there're some conflicts in this PR, would you like to fix them and merge this PR if you have...
> I can fix my own conflict ^^ That would be awesome, thanks @riderx! Let me know when it's done so I can merge it :)
Awesome, thanks @riderx