Failing Test

[zph]

Hello again!

I've been working on patches to automate the building of this on Github Actions across multiple architectures and platforms (ie aarch64 and x86_64 on both Linux and Mac).

During that I discovered that my own version of it is failing one specific test and I was surprised because I thought that's part of the CI baked into your repo.

Reporting it here in case this is not yet known.

PS - I've been happily using this for my team for the past 12 months and it's been a great help :). I have a few features I'd like to suggest and if time allows, build them and contribute upstream.

More important than fixing the test is also fixing any CI issue that allowed it to get into the codebase un-flagged.

Test error output:

> cargo test
running 29 tests
test commands::tests::test_should_source ... ok
test commands::tests::test_should_not_source ... ok
test commands::tests::test_usage ... ok
test commands::tests::test_help ... ok
test lib_tests::test_script_directory_argument ... ok
test lib_tests::test_directory_completion ... ok
test lib_tests::test_root_directory_completion ... ok
test lib_tests::test_exec_simple_script ... ok
test lib_tests::test_exec_recursive_simple_script ... ok
test lib_tests::test_script_in_directory_not_found ... ok
test lib_tests::test_dangerous_characters_quoted ... ok
test lib_tests::test_simple_script ... ok
test lib_tests::test_script_in_directory ... ok
test lib_tests::test_simple_script_with_args ... ok
test lib_tests::test_source ... ok
test lib_tests::test_simple_script_no_completion ... ok
test shell_type_tests::test_shell_type::case_1_bash ... ok
test shell_type_tests::test_shell_type::case_2_bin_bash ... ok
test lib_tests::test_tome_completion ... ok
test shell_type_tests::test_shell_type::case_3_zsh ... ok
test shell_type_tests::test_shell_type::case_4_bin_zsh ... ok
test shell_type_tests::test_shell_type::case_5_fish ... ok
test lib_tests::test_use_arg ... ok
test lib_tests::test_execute_help ... ok
test lib_tests::test_execute_commands ... ok
test lib_tests::test_help_page ... ok
test lib_tests::test_help_page_when_execute_no_args ... ok
test lib_tests::test_simple_script_completion ... FAILED
test lib_tests::test_source_completion ... ok

failures:

---- lib_tests::test_simple_script_completion stdout ----
thread 'lib_tests::test_simple_script_completion' panicked at 'assertion failed: `(left == right)`
  left: `Ok("")`,
 right: `Ok("file autocomplete example")`', src/lib_tests.rs:87:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    lib_tests::test_simple_script_completion

test result: FAILED. 28 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

error: test failed, to rerun pass `--lib`

No rush on this, I'll take a look as time allows.

Thanks!