tottoto comments

Results 27 comments of


                                            tottoto

Replace lazy_static crate with std::sync::OnceLock

I think this implementation would make the lock drop before panic which occurs when each test fails.

Replace lazy_static crate with std::sync::OnceLock

I think `drop` should be called before `resume_unwind`.

Replace lazy_static crate with std::sync::OnceLock

Do you have the reproduction which show that they behaves the same?

Replace lazy_static crate with std::sync::OnceLock

Thanks, I have known that behavior. In my test, without manually dropping the guard before calling resume_unwind, when one of the tests (which are called in this helper function) fails...

Replace lazy_static crate with std::sync::OnceLock

Yes, and more precisely, manual dropping is only necessary when the test fails, so it seems better to move it just before resume_unwind.

Replace lazy_static crate with std::sync::OnceLock

Thanks for another solution. Using `parking_lot` sounds good as well. Although in my opinion the mechanism which is implemented does not sound too complicated to exclude by using another crate...

fix(tls): encode der to pem

Addressed at #1707. Thank you!

Add zstd compression support

Resolved in #1532. Thank you!

Update socket2

Seems to have been resolved in #3314.

Update socket2

`socket2`'s ESP-IDF support is [backported to 0.4](https://github.com/rust-lang/socket2/pull/455) and [released at 0.4.10](https://github.com/rust-lang/socket2/blob/v0.4.10/CHANGELOG.md#0410).