Tor Harald Sandve
Tor Harald Sandve
Please update the documentation as you promised.
jenkins build this opm-simulators=6105 opm-tests=1311 please
Thanks for the update. I think what you did with the scaling factor is correct. Now, you only scale the equation for urea with a factor of 10. And not...
Thanks for the testing. From my point of view this is good to go. I will just rerun jenkins to make sure everything is fine.
I am fine with removing this if @steink agrees. But I have lately tested an approach that stops iterating (i.e. just give up) if it stagnates multiple times. This potentially...
I just added a draft PR that start using this part of the code https://github.com/OPM/opm-simulators/pull/6020 I think some code that detects stagnation / oscillation is a good idea.
If we are doing this only for output. I think a post processing like @vkip is suggestion is ok. But if we want to use this computed temperature for the...
jenkins build this please
jenkins build this failure_report please
Only one test failure. That is great! If we change MINNPCOL to 3 we should consider removing the keyword instead to simplify the logic. I will change this back to...