DeviceDetector.NET
DeviceDetector.NET copied to clipboard
totpero
Update device model database
I checked PHP implementation and the mobiles.yml cover a lot more devices.
https://github.com/matomo-org/device-detector/blob/master/regexes/device/mobiles.yml
The file used in this library is the same, but it is outdated since August 2021
Is it possible to update with the one listed above?
May I open a pull-request to update the file? I have it ready and tested locally. I was able to detect some new mobile devices in the market that the previous file was not able to.
Hi @fpl1976, yes you can contribute to this repo. We will appreciate any contribution. The update will fix this: #54 👍
Hi @fpl1976 You can fork this repo and create branch on your fork and after make the changes you can create pull request to this repo. Tx 👍
Hey @totpero
I have been running the tests (v6) and seen that for example the bots.yml fixture is producing errors because some entries do not have the producer node, therefore deserialization fails.
I am not really familiar with the YAML Parser library (FrontEnd Engineer 😄), so I guess a fix could be make the Producer object optional or with defaults in the Bot.cs class, if that is a possible setup in the YAML parser.
What do you think?
Hi @FelixPradosFL, I have fix most of the tests, there are only 3 tests that not pass. I will fix them all. Thanks for your contribution.
Awesome @totpero By the way, I am the same user as @fpl1976 , just using the company email
Hi @totpero can you also authorize me to push using my @FelixPradosFL user? I have been fixing the failing tests for v6 and now everything is working locally
@FelixPradosFL you just change the fixtures yaml file to pass the tests but this is not the solution, is just a hack. We need to fix the code to pass all the tests. If the original test scenario say that the model is "Chrome Mobile" you can't just change to "Chromium". We need to pass the tests with the original php yaml files. If the yaml test files is like in your commit, the change the file to the original php repo and after we will get the files from there. Thanks for your contribution 👍
Hi @totpero going to take a second look. Will get the files from the php repo again.
I don't really understand that XXX TEST userAgent string for Dell. Seems like it is not a real userAgent string.
About the Chrome Mobile vs Chromium, to me also seemed that for desktop fixtures the latest Chrome versions return Chromium as browser_family.
Will continue investigation, thx for your feedback.
Since I am not very familiar with the code I am trying to figure out why some very specific userAgent strings in the fixtures are failing.