ts-reset fix: JSON.parse accepting null

fix: JSON.parse accepting null

Open ImLunaHey opened this issue 2 years ago • 4 comments

Please let me know if I missed anything in this.

Fixes: https://github.com/total-typescript/ts-reset/issues/173

Oct 18 '23 01:10 ImLunaHey

Argument name should not change.

Jan 23 '24 16:01 qb20nh

it should never have been called text to begin with. it's a value.

Jan 23 '24 21:01 ImLunaHey

That is not a typescript issue.

Jan 24 '24 06:01 qb20nh

For completeness and consistency, we should generalize to all valid JSON string producing text values.

parse<T extends boolean | number | bigint>(text: T, /*...*/): T
parse<T extends boolean | number | bigint | null>(text: T, /*...*/): unknown

Jan 25 '24 10:01 qb20nh