[Feature]: Please, adding the on and off feature of dark mode. 😊

[kss2002]

In other overlay-kit sites, use-funnel, and es-toolkit, there is a button to turn on/off the dark mode, but it does not exist in Suspense.

From the developer's point of view, a dark site would be good for visibility, but from the user's point of view, it would be good to turn on/off the dark mode as you please.

We insert a function to turn on/off the related dark mode, and propose the overall function that can be controlled by the button as an issue.

Thank you.

https://suspensive.org/ko

[coauthors[bot]]

People can be co-author:

Candidate	Reasons	Count	Add this as commit message
@kss2002	https://github.com/toss/suspensive/issues/1508#issuecomment-2778071606 https://github.com/toss/suspensive/issues/1508#issuecomment-2778103843 https://github.com/toss/suspensive/issues/1508 https://github.com/toss/suspensive/issues/1508#issuecomment-3044868966 https://github.com/toss/suspensive/issues/1508#issuecomment-3290786255 https://github.com/toss/suspensive/issues/1508#issuecomment-3292645497 https://github.com/toss/suspensive/issues/1508#issuecomment-3292685615 https://github.com/toss/suspensive/issues/1508#issuecomment-3301141796 https://github.com/toss/suspensive/issues/1508#issuecomment-3317402226 https://github.com/toss/suspensive/issues/1508#issuecomment-3355775837	10	Co-authored-by: kss2002 <[email protected]>
@manudeli	https://github.com/toss/suspensive/issues/1508#issuecomment-2774867399 https://github.com/toss/suspensive/issues/1508#issuecomment-3292512329 https://github.com/toss/suspensive/issues/1508#issuecomment-3292658891 https://github.com/toss/suspensive/issues/1508#issuecomment-3301214269 https://github.com/toss/suspensive/issues/1508#issuecomment-3317732308 https://github.com/toss/suspensive/issues/1508#issuecomment-3355069546	6	Co-authored-by: manudeli <[email protected]>
@gwansikk	https://github.com/toss/suspensive/issues/1508#issuecomment-2774762659 https://github.com/toss/suspensive/issues/1508#issuecomment-2780209779 https://github.com/toss/suspensive/issues/1508#issuecomment-3045442509	3	Co-authored-by: gwansikk <[email protected]>
@sukvvon	https://github.com/toss/suspensive/issues/1508#issuecomment-3355051109	1	Co-authored-by: sukvvon <[email protected]>

[gwansikk]

Thank you for suggesting this issue. Currently, Suspensive's official documentation supports only dark mode, in line with the project's branding concept. However, we will discuss internally whether to add light mode support.

cc. @manudeli

[manudeli]

@kss2002 I agree that feature to toggle light/dark mode would be also good to have. but It's not must. In my opinion, We don't have enough human resource to maintain light mode before preparing suspensive v3. but you can contribute to it. could you please?

[kss2002]

Thank you for considering the issue I presented.

@gwansikk

[kss2002]

@gwansikk I think it's a great opportunity. I don't have any experience in contributing to open source yet, but I would like to take this opportunity to contribute while learning.

If you have any questions in the process of adding features, is it okay if I ask you a question? Thank you 🔥

[gwansikk]

If you have any questions in the process of adding features, is it okay if I ask you a question?

Of course, contributions are welcome 💪💪

[kss2002]

Hi! I tried to run the project with pnpm dev, but it seems like @suspensive/react-query-4 module is missing and causing build errors. Is this package under development or am I missing some setup steps? I want to launch a preview server but it's failing. 😣😣

[gwansikk]

Hi! I tried to run the project with pnpm dev, but it seems like @suspensive/react-query-4 module is missing and causing build errors. Is this package under development or am I missing some setup steps? I want to launch a preview server but it's failing. 😣😣

Could you run pnpm install once after pnpm build? If you want to run the official documentation locally, try using pnpm -F @suspensive/suspensive.org dev.

[kss2002]

Hello!

When proceeding with git clones, is it cloning my repository that forked this suspenseful or is it cloning the actual suspenseful of this toss now? I'm curious!

• (As far as I understand, "cloning my repository that forked this suspense" is correct.)

[manudeli]

Hello!

When proceeding with git clones, is it cloning my repository that forked this suspenseful or is it cloning the actual suspenseful of this toss now? I'm curious!

• (As far as I understand, "cloning my repository that forked this suspense" is correct.)

저희 레포지토리와 프로젝트 이름은 Suspensive이에요. 괜찮으시다면 한국어로 말씀주셔도 좋을 것 같아요

[kss2002]

Hello! When proceeding with git clones, is it cloning my repository that forked this suspenseful or is it cloning the actual suspenseful of this toss now? I'm curious!

• (As far as I understand, "cloning my repository that forked this suspense" is correct.)

저희 레포지토리와 프로젝트 이름은 Suspensive이에요. 괜찮으시다면 한국어로 말씀주셔도 좋을 것 같아요

네 알겠습니다!

지금 현재 이 토스의 Suspensive 레포지토리를 fork한 상태이고 fork한 레포지토리를 "클론"하는 흐름이 맞는지가 궁금합니다! ( fork한 제 레포지토리 링크 > https://github.com/kss2002/suspensive )

[manudeli]

넵넵! 기여를 하고자 하셔서 포크하시고 클론 받으신거죠? 그렇다면 맞습니다

[kss2002]

넵넵! 기여를 하고자 하셔서 포크하시고 클론 받으신거죠? 그렇다면 맞습니다

감사합니다! 확인하였습니다!

[kss2002]

안녕하세요! "다크모드" 토글 버튼 구현에 대해 의견을 여쭈고 싶어서 이렇게 comment를 남깁니다. 버튼의 구현 위치를 어디에 위치하는 것이 좋을까요? PC 스케일에서 [header 쪽의 "문서보기" 왼쪽] or [footer 쪽의 🌐한국어 (언어설정)의 오른쪽] 정도를 생각하고 있으며 모바일 스케일에서는 [header의 깃허브 이모티콘 왼쪽]에 위치할 생각입니다.

언제든지 편하게 의견 남겨주시면 많은 도움이 될 거 같습니다. 감사합니다

[manudeli]

우선은 기능이 있는 것이 중요한 거 같아서 어떤 방향이든 PR올려주시면 위치나 상세한 디자인은 차차 잡아가보아도 좋을 거 같아요

[kss2002]

기능을 어느정도 추가해둔 상황인데, 아직 완성형은 아닙니다! 코드 리뷰를 위해 PR 올려도 괜찮을까요?

[manudeli]

넵 올려도 괜찮습니다

[sukvvon]

@manudeli

I think we can close this issue. ☺️

• #1755

[manudeli]

@kss2002 Thanks!

[kss2002]

Thank you so much for taking the precious time to review the code! 👩‍💻