suspensive icon indicating copy to clipboard operation
suspensive copied to clipboard

ci(*): typescript-eslint 8

Open vr-varad opened this issue 1 year ago • 11 comments

Overview

PR Checklist

  • [ ] I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

vr-varad avatar Aug 31 '24 14:08 vr-varad

People can be co-author:

Candidate Reasons Count Add this as commit message
@vr-varad https://github.com/toss/suspensive/pull/1240#issuecomment-2322907722 https://github.com/toss/suspensive/pull/1240#issuecomment-2322942574 https://github.com/toss/suspensive/pull/1240#issuecomment-2326747482 https://github.com/toss/suspensive/pull/1240 4 Co-authored-by: vr-varad <[email protected]>
@manudeli https://github.com/toss/suspensive/pull/1240#issuecomment-2322917332 https://github.com/toss/suspensive/pull/1240#issuecomment-2326738170 https://github.com/toss/suspensive/pull/1240#issuecomment-2423729471 3 Co-authored-by: manudeli <[email protected]>
@saul-atomrigs https://github.com/toss/suspensive/pull/1240#issuecomment-2361859199 https://github.com/toss/suspensive/pull/1240#issuecomment-2361872775 2 Co-authored-by: saul-atomrigs <[email protected]>

coauthors[bot] avatar Aug 31 '24 14:08 coauthors[bot]

⚠️ No Changeset found

Latest commit: 488d9f7e4d422b7747f6c02a557167e1fe055bb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 31 '24 14:08 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2024 2:48pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2024 2:48pm

vercel[bot] avatar Aug 31 '24 14:08 vercel[bot]

Someone is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 31 '24 14:08 vercel[bot]

@manudeli

vr-varad avatar Aug 31 '24 14:08 vr-varad

@vr-varad Could you resolve ci:eslint error please?

manudeli avatar Aug 31 '24 14:08 manudeli

0:0 error Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser. The file was not found in any of the provided project(s): eslint.config.mjs I am getting this error in suspensive/examples/vite-react-18-suspense-prerender-siblings-problem/eslint.config.mjs, do u have any idea what's it about? @manudeli

vr-varad avatar Aug 31 '24 15:08 vr-varad

0:0 error Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser. The file was not found in any of the provided project(s): eslint.config.mjs I am getting this error in suspensive/examples/vite-react-18-suspense-prerender-siblings-problem/eslint.config.mjs, do u have any idea what's it about? @manudeli

So I need your help..! Actually I got same error before. Could you resolve that error please?

manudeli avatar Sep 03 '24 14:09 manudeli

Will try my best !!!

vr-varad avatar Sep 03 '24 14:09 vr-varad

The no-throw-literal rule has been renamed to only-throw-error (https://github.com/typescript-eslint/typescript-eslint/pull/8701). So for https://github.com/toss/suspensive/pull/1240#issuecomment-2322917332, I think instead of https://github.com/toss/suspensive/pull/1240/commits/488d9f7e4d422b7747f6c02a557167e1fe055bb3, it's better to use only-throw-error:

'@typescript-eslint/only-throw-error': 'warn',

saul-atomrigs avatar Sep 19 '24 18:09 saul-atomrigs

0:0 error Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser. The file was not found in any of the provided project(s): eslint.config.mjs I am getting this error in suspensive/examples/vite-react-18-suspense-prerender-siblings-problem/eslint.config.mjs, do u have any idea what's it about? @manudeli

This error log is mentioned in recent typescript-eslint issues (https://github.com/typescript-eslint/typescript-eslint/issues/9774, https://github.com/typescript-eslint/typescript-eslint/issues/9749). It seems like the solution is adding allowJs to the tsconfig.jsons, but in my case doing this leads to hidden lint errors being thrown, which are quite a lot.....

saul-atomrigs avatar Sep 19 '24 18:09 saul-atomrigs

I close this Pull Request because of #1326. @SEOKKAMONI but co-author please these people(@vr-varad, @saul-atomrigs) too. We struggled to solve this issue in this pull request

manudeli avatar Oct 19 '24 09:10 manudeli