suspensive icon indicating copy to clipboard operation
suspensive copied to clipboard

[Feature]: Update pnpm v8 to v9

Open sungh0lim opened this issue 1 year ago • 8 comments

Package Scope

etc

Description

Have you looked at the release of pnpm v9.0.0 by any chance?

These changes will be good for suspensive.

  • Corepack compatiblity
  • Lockfile changes

Possible Solution

No response

etc.

No response

sungh0lim avatar Aug 06 '24 15:08 sungh0lim

Thanks for your suggestion. Already I knew it. but It had bug for our release process related with pnpm 9. and Suspensive use peerDependency as very seriously

image

When this bug fixed, I'll try it 🙇

manudeli avatar Aug 06 '24 16:08 manudeli

Your contribution will be also good for us if you okay! 👍

manudeli avatar Aug 06 '24 16:08 manudeli

Could you explain bug with peerDependency?

sungh0lim avatar Aug 06 '24 16:08 sungh0lim

Could you explain bug with peerDependency?

When using PNPM 9, workspace:^2.9.0 changes to ^2.9.02.9.0 at publish time. Our expected outcome was ^2.9.0, and this worked correctly in PNPM 8. 🥲

manudeli avatar Aug 06 '24 16:08 manudeli

I'll try it this weekend :)

sungh0lim avatar Aug 06 '24 16:08 sungh0lim

  • https://github.com/pnpm/pnpm/issues/8355

I have found a similar issue.

gwansikk avatar Aug 06 '24 23:08 gwansikk

When using PNPM 9, workspace:^2.9.0 changes to ^2.9.02.9.0 at publish time. Our expected outcome was ^2.9.0, and this worked correctly in PNPM 8. 🥲

@manudeli @sungh0lim I'm working on trying to resolve that issue.

  • https://github.com/pnpm/pnpm/pull/8383

gwansikk avatar Aug 07 '24 07:08 gwansikk

@gwansikk's pull request is merged. let's do this issue. I'll assign @sungh0lim on this issue

manudeli avatar Aug 14 '24 05:08 manudeli

@gwansikk It's so cool!!! When https://github.com/pnpm/pnpm/pull/8383 deployed, I update pnpm version of suspensive.

sungh0lim avatar Aug 15 '24 14:08 sungh0lim

@gwansikk It's so cool!!! When pnpm/pnpm#8383 deployed, I update pnpm version of suspensive.

It has been released with [email protected]!​

  • https://github.com/pnpm/pnpm/releases/tag/v9.7.1

gwansikk avatar Aug 15 '24 16:08 gwansikk

coauthors test

manudeli avatar Aug 16 '24 06:08 manudeli

People can be co-author:

Candidate Reasons Count Add this as commit message
@sungh0lim https://github.com/toss/suspensive/issues/1199#issuecomment-2271650265 https://github.com/toss/suspensive/issues/1199#issuecomment-2271662739 https://github.com/toss/suspensive/issues/1199#issuecomment-2291361986 https://github.com/toss/suspensive/issues/1199 4 Co-authored-by: sungh0lim <[email protected]>
@manudeli https://github.com/toss/suspensive/issues/1199#issuecomment-2271645158 https://github.com/toss/suspensive/issues/1199#issuecomment-2271646996 https://github.com/toss/suspensive/issues/1199#issuecomment-2271658308 https://github.com/toss/suspensive/issues/1199#issuecomment-2287872236 https://github.com/toss/suspensive/issues/1199#issuecomment-2292898652 5 Co-authored-by: manudeli <[email protected]>
@gwansikk https://github.com/toss/suspensive/issues/1199#issuecomment-2272301127 https://github.com/toss/suspensive/issues/1199#issuecomment-2272784487 https://github.com/toss/suspensive/issues/1199#issuecomment-2291684000 3 Co-authored-by: gwansikk <[email protected]>

coauthors[bot] avatar Aug 16 '24 06:08 coauthors[bot]