suspensive icon indicating copy to clipboard operation
suspensive copied to clipboard

feat(react-dom): add InView, useInView

Open manudeli opened this issue 1 year ago • 2 comments
trafficstars

related with #1071

Overview

PR Checklist

  • [x] I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

manudeli avatar Aug 03 '24 11:08 manudeli

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 10:25am
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 10:25am
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 10:25am

vercel[bot] avatar Aug 03 '24 11:08 vercel[bot]

⚠️ No Changeset found

Latest commit: 26910b7df2053f16dcf1d0d2aa63c8850b814ad1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 03 '24 11:08 changeset-bot[bot]

coauthors test

manudeli avatar Aug 15 '24 15:08 manudeli

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli https://github.com/toss/suspensive/pull/1184#discussion_r1740119623 https://github.com/toss/suspensive/pull/1184#discussion_r1740149870 https://github.com/toss/suspensive/pull/1184#pullrequestreview-2274398572 https://github.com/toss/suspensive/pull/1184#pullrequestreview-2274444477 https://github.com/toss/suspensive/pull/1184#issuecomment-2291519316 https://github.com/toss/suspensive/pull/1184#issuecomment-2323213612 https://github.com/toss/suspensive/pull/1184 7 Co-authored-by: manudeli <[email protected]>
@SEOKKAMONI https://github.com/toss/suspensive/pull/1184#discussion_r1740037928 https://github.com/toss/suspensive/pull/1184#discussion_r1740038553 https://github.com/toss/suspensive/pull/1184#discussion_r1740040883 https://github.com/toss/suspensive/pull/1184#discussion_r1740043724 https://github.com/toss/suspensive/pull/1184#discussion_r1740044575 https://github.com/toss/suspensive/pull/1184#pullrequestreview-2274279157 6 Co-authored-by: SEOKKAMONI <[email protected]>
@codecov-commenter https://github.com/toss/suspensive/pull/1184#issuecomment-2308646902 1 Co-authored-by: codecov-commenter <[email protected]>
@gwansikk https://github.com/toss/suspensive/pull/1184#pullrequestreview-2279561526 1 Co-authored-by: gwansikk <[email protected]>

coauthors[bot] avatar Aug 15 '24 15:08 coauthors[bot]

Size Change: +620 B (+0.54%)

Total Size: 115 kB

Filename Size Change
packages/react-dom/dist/chunk-YJUMTHWY.js 0 B -189 B (removed) 🏆
packages/react-dom/dist/index.cjs 2.11 kB +1.51 kB (+250.33%) 🆘
packages/react-dom/dist/index.js 139 B +17 B (+13.93%) ⚠️
packages/react-dom/dist/TestText.cjs 0 B -596 B (removed) 🏆
packages/react-dom/dist/TestText.js 0 B -119 B (removed) 🏆
ℹ️ View Unchanged
Filename Size
packages/cache/dist/Cache.cjs 1.7 kB
packages/cache/dist/Cache.js 129 B
packages/cache/dist/cacheOptions.cjs 539 B
packages/cache/dist/cacheOptions.js 136 B
packages/cache/dist/CacheProvider.cjs 655 B
packages/cache/dist/CacheProvider.js 147 B
packages/cache/dist/chunk-27UYQ7PV.js 250 B
packages/cache/dist/chunk-5VXONFWZ.js 291 B
packages/cache/dist/chunk-ANHYGXTE.js 1.2 kB
packages/cache/dist/chunk-DP7DNUTU.js 159 B
packages/cache/dist/chunk-ETI64SK7.js 244 B
packages/cache/dist/chunk-QETBZSG5.js 521 B
packages/cache/dist/chunk-QQAFR2PG.js 252 B
packages/cache/dist/chunk-RN456Z2W.js 145 B
packages/cache/dist/index.cjs 2.2 kB
packages/cache/dist/index.js 240 B
packages/cache/dist/Read.cjs 982 B
packages/cache/dist/Read.js 157 B
packages/cache/dist/types.cjs 416 B
packages/cache/dist/types.js 66 B
packages/cache/dist/useCache.cjs 652 B
packages/cache/dist/useCache.js 142 B
packages/cache/dist/useRead.cjs 728 B
packages/cache/dist/useRead.js 150 B
packages/jotai/dist/Atom.cjs 660 B
packages/jotai/dist/Atom.js 115 B
packages/jotai/dist/AtomValue.cjs 647 B
packages/jotai/dist/AtomValue.js 120 B
packages/jotai/dist/chunk-3QYJXA7E.js 245 B
packages/jotai/dist/chunk-DO5S4NAM.js 241 B
packages/jotai/dist/chunk-VT4GDWF6.js 264 B
packages/jotai/dist/index.cjs 755 B
packages/jotai/dist/index.js 158 B
packages/jotai/dist/SetAtom.cjs 645 B
packages/jotai/dist/SetAtom.js 118 B
packages/react-dom/dist/chunk-GJKK7GK5.js 1.71 kB
packages/react-dom/dist/chunk-WXC47UUD.js 282 B
packages/react-dom/dist/InView.cjs 2.1 kB
packages/react-dom/dist/InView.js 130 B
packages/react-dom/dist/useInView.cjs 1.87 kB
packages/react-dom/dist/useInView.js 120 B
packages/react-image/dist/chunk-3AXMXK3U.js 1.11 kB
packages/react-image/dist/chunk-L5OGXK7B.js 405 B
packages/react-image/dist/index.cjs 1.54 kB
packages/react-image/dist/index.js 140 B
packages/react-image/dist/Load.cjs 1.32 kB
packages/react-image/dist/Load.js 126 B
packages/react-image/dist/SuspenseImage.cjs 1.53 kB
packages/react-image/dist/SuspenseImage.js 137 B
packages/react-native/dist/chunk-45D2JR5L.js 205 B
packages/react-native/dist/index.cjs 619 B
packages/react-native/dist/index.js 122 B
packages/react-native/dist/TestText.cjs 612 B
packages/react-native/dist/TestText.js 119 B
packages/react-query-4/dist/chunk-4AU4A5TK.js 312 B
packages/react-query-4/dist/chunk-7LC5EH5R.js 308 B
packages/react-query-4/dist/chunk-E6ZR4G6A.js 250 B
packages/react-query-4/dist/chunk-HJAGY6R3.js 254 B
packages/react-query-4/dist/chunk-INXQLUAG.js 151 B
packages/react-query-4/dist/chunk-JMZC2U4M.js 306 B
packages/react-query-4/dist/chunk-JSOYNYMT.js 254 B
packages/react-query-4/dist/chunk-NKKRZH3C.js 269 B
packages/react-query-4/dist/chunk-P5MROV72.js 470 B
packages/react-query-4/dist/chunk-Q4KHEUPO.js 145 B
packages/react-query-4/dist/chunk-QETBZSG5.js 521 B
packages/react-query-4/dist/chunk-S7L2LUVS.js 277 B
packages/react-query-4/dist/chunk-W3SOIIM5.js 273 B
packages/react-query-4/dist/index.cjs 1.74 kB
packages/react-query-4/dist/index.js 344 B
packages/react-query-4/dist/infiniteQueryOptions.cjs 548 B
packages/react-query-4/dist/infiniteQueryOptions.js 144 B
packages/react-query-4/dist/Mutation.cjs 821 B
packages/react-query-4/dist/Mutation.js 132 B
packages/react-query-4/dist/QueryErrorBoundary.cjs 1.12 kB
packages/react-query-4/dist/QueryErrorBoundary.js 142 B
packages/react-query-4/dist/queryOptions.cjs 540 B
packages/react-query-4/dist/queryOptions.js 135 B
packages/react-query-4/dist/SuspenseInfiniteQuery.cjs 1.05 kB
packages/react-query-4/dist/SuspenseInfiniteQuery.js 154 B
packages/react-query-4/dist/SuspenseQueries.cjs 923 B
packages/react-query-4/dist/SuspenseQueries.js 149 B
packages/react-query-4/dist/SuspenseQuery.cjs 1.04 kB
packages/react-query-4/dist/SuspenseQuery.js 147 B
packages/react-query-4/dist/usePrefetchInfiniteQuery.cjs 648 B
packages/react-query-4/dist/usePrefetchInfiniteQuery.js 148 B
packages/react-query-4/dist/usePrefetchQuery.cjs 639 B
packages/react-query-4/dist/usePrefetchQuery.js 140 B
packages/react-query-4/dist/useSuspenseInfiniteQuery.cjs 833 B
packages/react-query-4/dist/useSuspenseInfiniteQuery.js 147 B
packages/react-query-4/dist/useSuspenseQueries.cjs 833 B
packages/react-query-4/dist/useSuspenseQueries.js 142 B
packages/react-query-4/dist/useSuspenseQuery.cjs 824 B
packages/react-query-4/dist/useSuspenseQuery.js 140 B
packages/react-query-5/dist/chunk-4MX6YXXC.js 471 B
packages/react-query-5/dist/chunk-77J6GDKL.js 172 B
packages/react-query-5/dist/chunk-DJYUEMUX.js 177 B
packages/react-query-5/dist/chunk-FKG24WFN.js 170 B
packages/react-query-5/dist/chunk-G4UWQXSU.js 310 B
packages/react-query-5/dist/chunk-GXSI7FXZ.js 306 B
packages/react-query-5/dist/chunk-KI4RNNHO.js 173 B
packages/react-query-5/dist/chunk-LHMCCR64.js 262 B
packages/react-query-5/dist/chunk-LQDNL5GK.js 172 B
packages/react-query-5/dist/chunk-QETBZSG5.js 521 B
packages/react-query-5/dist/chunk-RX5QN4OH.js 167 B
packages/react-query-5/dist/chunk-XFQQRL67.js 319 B
packages/react-query-5/dist/chunk-XRWCGESR.js 168 B
packages/react-query-5/dist/index.cjs 1.62 kB
packages/react-query-5/dist/index.js 343 B
packages/react-query-5/dist/infiniteQueryOptions.cjs 573 B
packages/react-query-5/dist/infiniteQueryOptions.js 144 B
packages/react-query-5/dist/Mutation.cjs 821 B
packages/react-query-5/dist/Mutation.js 132 B
packages/react-query-5/dist/QueryErrorBoundary.cjs 1.12 kB
packages/react-query-5/dist/QueryErrorBoundary.js 142 B
packages/react-query-5/dist/queryOptions.cjs 563 B
packages/react-query-5/dist/queryOptions.js 136 B
packages/react-query-5/dist/SuspenseInfiniteQuery.cjs 833 B
packages/react-query-5/dist/SuspenseInfiniteQuery.js 145 B
packages/react-query-5/dist/SuspenseQueries.cjs 671 B
packages/react-query-5/dist/SuspenseQueries.js 139 B
packages/react-query-5/dist/SuspenseQuery.cjs 825 B
packages/react-query-5/dist/SuspenseQuery.js 137 B
packages/react-query-5/dist/usePrefetchInfiniteQuery.cjs 577 B
packages/react-query-5/dist/usePrefetchInfiniteQuery.js 148 B
packages/react-query-5/dist/usePrefetchQuery.cjs 569 B
packages/react-query-5/dist/usePrefetchQuery.js 140 B
packages/react-query-5/dist/useSuspenseInfiniteQuery.cjs 577 B
packages/react-query-5/dist/useSuspenseInfiniteQuery.js 148 B
packages/react-query-5/dist/useSuspenseQueries.cjs 571 B
packages/react-query-5/dist/useSuspenseQueries.js 142 B
packages/react-query-5/dist/useSuspenseQuery.cjs 569 B
packages/react-query-5/dist/useSuspenseQuery.js 140 B
packages/react-query-next-experimental-4/dist/chunk-K27XTU36.js 1.04 kB
packages/react-query-next-experimental-4/dist/chunk-QNL5HUNI.js 797 B
packages/react-query-next-experimental-4/dist/chunk-RGU7T7L7.js 570 B
packages/react-query-next-experimental-4/dist/htmlescape.cjs 656 B
packages/react-query-next-experimental-4/dist/htmlescape.js 133 B
packages/react-query-next-experimental-4/dist/HydrationStreamProvider.cjs 1.79 kB
packages/react-query-next-experimental-4/dist/HydrationStreamProvider.js 156 B
packages/react-query-next-experimental-4/dist/index.cjs 2.41 kB
packages/react-query-next-experimental-4/dist/index.js 162 B
packages/react-query-next-experimental-4/dist/ReactQueryStreamedHydration.cjs 2.41 kB
packages/react-query-next-experimental-4/dist/ReactQueryStreamedHydration.js 164 B
packages/react-query-next-experimental/dist/index.cjs 595 B
packages/react-query-next-experimental/dist/index.js 161 B
packages/react-query/dist/index.cjs 551 B
packages/react-query/dist/index.js 121 B
packages/react-query/dist/v4.cjs 550 B
packages/react-query/dist/v4.js 116 B
packages/react-query/dist/v5.cjs 550 B
packages/react-query/dist/v5.js 116 B
packages/react/dist/chunk-2YNK4Y6O.js 819 B
packages/react/dist/chunk-3L5P33J5.js 414 B
packages/react/dist/chunk-6NAWCGK4.js 596 B
packages/react/dist/chunk-6NIZONXB.js 1.64 kB
packages/react/dist/chunk-CTXF3WOZ.js 246 B
packages/react/dist/chunk-HVDFXOFP.js 414 B
packages/react/dist/chunk-INLOGI26.js 282 B
packages/react/dist/chunk-KBH2PMLJ.js 578 B
packages/react/dist/chunk-NF2UFYHD.js 433 B
packages/react/dist/chunk-TTRGFZ2C.js 136 B
packages/react/dist/chunk-TWMWHMZ5.js 353 B
packages/react/dist/chunk-UHZ42BSU.js 448 B
packages/react/dist/chunk-UORT4Q26.js 668 B
packages/react/dist/chunk-WQJTGHBN.js 517 B
packages/react/dist/ClientOnly.cjs 736 B
packages/react/dist/ClientOnly.js 141 B
packages/react/dist/DefaultProps.cjs 1.05 kB
packages/react/dist/DefaultProps.js 167 B
packages/react/dist/Delay.cjs 1.11 kB
packages/react/dist/Delay.js 149 B
packages/react/dist/DevMode.cjs 530 B
packages/react/dist/DevMode.js 131 B
packages/react/dist/ErrorBoundary.cjs 2.74 kB
packages/react/dist/ErrorBoundary.js 206 B
packages/react/dist/ErrorBoundaryGroup.cjs 1.37 kB
packages/react/dist/ErrorBoundaryGroup.js 180 B
packages/react/dist/index.cjs 4.19 kB
packages/react/dist/index.js 369 B
packages/react/dist/Suspense.cjs 1.3 kB
packages/react/dist/Suspense.js 172 B
packages/react/dist/Suspensive.cjs 1.26 kB
packages/react/dist/Suspensive.js 175 B
packages/react/dist/wrap.cjs 3.67 kB
packages/react/dist/wrap.js 209 B
packages/utils/dist/chunk-5XT623M4.js 263 B
packages/utils/dist/chunk-FWXVSCJA.js 125 B
packages/utils/dist/chunk-OSQ3QLKJ.js 276 B
packages/utils/dist/chunk-PKN4LMAV.js 137 B
packages/utils/dist/chunk-TUVDYELP.js 191 B
packages/utils/dist/ConstructorType.cjs 424 B
packages/utils/dist/ConstructorType.js 76 B
packages/utils/dist/increase.cjs 533 B
packages/utils/dist/increase.js 119 B
packages/utils/dist/index.cjs 1.58 kB
packages/utils/dist/index.js 926 B
packages/utils/dist/noop.cjs 522 B
packages/utils/dist/noop.js 115 B
packages/utils/dist/Nullable.cjs 419 B
packages/utils/dist/Nullable.js 69 B
packages/utils/dist/OmitKeyof.cjs 420 B
packages/utils/dist/OmitKeyof.js 70 B
packages/utils/dist/RequiredKeyof.cjs 425 B
packages/utils/dist/RequiredKeyof.js 74 B
packages/utils/dist/useIsomorphicLayoutEffect.cjs 588 B
packages/utils/dist/useIsomorphicLayoutEffect.js 136 B
packages/utils/dist/usePreservedCallback.cjs 697 B
packages/utils/dist/usePreservedCallback.js 144 B
packages/utils/dist/useTimeout.cjs 769 B
packages/utils/dist/useTimeout.js 144 B

compressed-size-action

github-actions[bot] avatar Aug 21 '24 09:08 github-actions[bot]

CodSpeed Performance Report

Merging #1184 will create unknown performance changes

Comparing react-dom/feat/InView (26910b7) with main (da590b7)

Summary

:warning: No benchmarks were detected in both the base of the PR and the PR.

codspeed-hq[bot] avatar Aug 24 '24 05:08 codspeed-hq[bot]

Codecov Report

Attention: Patch coverage is 96.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.47%. Comparing base (da590b7) to head (26910b7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   69.51%   74.47%   +4.95%     
==========================================
  Files          74       77       +3     
  Lines         666      815     +149     
  Branches      133      182      +49     
==========================================
+ Hits          463      607     +144     
- Misses        179      184       +5     
  Partials       24       24              
Components Coverage Δ
@suspensive/utils 47.16% <ø> (ø)
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 96.66% <96.66%> (-3.34%) :arrow_down:
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 72.09% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/react-query-next-experimental ∅ <ø> (∅)
@suspensive/react-query-next-experimental-4 6.15% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/cache 98.01% <ø> (ø)
@suspensive/react-image 80.39% <ø> (ø)

codecov-commenter avatar Aug 25 '24 04:08 codecov-commenter

This is quite big change. Could I request this Pull Request you guys? @gwansikk @kangju2000 @bigsaigon333 @SEOKKAMONI

manudeli avatar Sep 01 '24 07:09 manudeli