suspensive icon indicating copy to clipboard operation
suspensive copied to clipboard

Published 20 hours ago • verified publisher icon toss

feat(react-query-v4): react-query-next-experimental

Open 2-NOW opened this issue 1 year ago • 9 comments

Overview

close: #1155

Adds a streaming without prefetching feature that brings the react-query-next-experimental feature available in react-query v5 to v4

  • [x] Add a default implementation
    • HydrationStreamProvider
    • ReactQueryStreamedHydration
  • [ ] Test working well

PR Checklist

  • [x] I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

2-NOW avatar Jul 29 '24 14:07 2-NOW

🦋 Changeset detected

Latest commit: 1b54bc2b8216af025e581857a5bcc34ad4e38a1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@suspensive/react-query-next-experimental-4 Patch
@suspensive/react-query-next-experimental-4-example Patch
@suspensive/react-query-next-experimental Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 29 '24 14:07 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2024 2:08pm
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2024 2:08pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2024 2:08pm

vercel[bot] avatar Jul 29 '24 14:07 vercel[bot]

@2-NOW is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jul 29 '24 14:07 vercel[bot]

CodSpeed Performance Report

Merging #1161 will create unknown performance changes

Comparing 2-NOW:react-query-v4-streaming-experimental (1b54bc2) with main (c179a56)

Summary

:warning: No benchmarks were detected in both the base of the PR and the PR.

codspeed-hq[bot] avatar Jul 29 '24 14:07 codspeed-hq[bot]

Codecov Report

Attention: Patch coverage is 6.15385% with 61 lines in your changes missing coverage. Please review.

Project coverage is 70.57%. Comparing base (c179a56) to head (1b54bc2). Report is 306 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
- Coverage   77.66%   70.57%   -7.09%     
==========================================
  Files          67       70       +3     
  Lines         591      656      +65     
  Branches      117      131      +14     
==========================================
+ Hits          459      463       +4     
- Misses        123      171      +48     
- Partials        9       22      +13
Components Coverage Δ
@suspensive/utils 47.16% <ø> (ø)
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 100.00% <ø> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 72.09% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/react-query-next-experimental ∅ <ø> (∅)
@suspensive/react-query-next-experimental-4 6.15% <6.15%> (∅)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/cache 98.01% <ø> (ø)
@suspensive/react-image 80.39% <ø> (ø)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jul 29 '24 15:07 codecov-commenter

Is there a template or rule for creating new package? If there are conventions for the repository here, I'd be happy to know about them

2-NOW avatar Jul 29 '24 16:07 2-NOW

@2-NOW Welcome🙇 I added commit 65d2fc4 to support you to get playground and convention

manudeli avatar Jul 29 '24 18:07 manudeli

@manudeli It seems that something went wrong due to a forced push. It needs to be checked.

SEOKKAMONI avatar Aug 04 '24 15:08 SEOKKAMONI

@manudeli It seems that something went wrong due to a forced push. It needs to be checked.

Changed history to match the changed target :) Thanks for checking @SEOKKAMONI

2-NOW avatar Aug 04 '24 15:08 2-NOW

coauthors test

manudeli avatar Aug 15 '24 15:08 manudeli

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli https://github.com/toss/suspensive/pull/1161#discussion_r1720982102 https://github.com/toss/suspensive/pull/1161#discussion_r1720982416 https://github.com/toss/suspensive/pull/1161#discussion_r1720982476 https://github.com/toss/suspensive/pull/1161#discussion_r1720982523 https://github.com/toss/suspensive/pull/1161#pullrequestreview-2244318837 https://github.com/toss/suspensive/pull/1161#pullrequestreview-2244319170 https://github.com/toss/suspensive/pull/1161#issuecomment-2256662706 https://github.com/toss/suspensive/pull/1161#issuecomment-2291561172 https://github.com/toss/suspensive/pull/1161#issuecomment-2292774980 https://github.com/toss/suspensive/pull/1161#issuecomment-2294520347 https://github.com/toss/suspensive/pull/1161#issuecomment-2295236430 11 Co-authored-by: manudeli <[email protected]>
@2-NOW https://github.com/toss/suspensive/pull/1161#issuecomment-2256348553 https://github.com/toss/suspensive/pull/1161#issuecomment-2267584856 https://github.com/toss/suspensive/pull/1161#issuecomment-2293824620 https://github.com/toss/suspensive/pull/1161#issuecomment-2295230635 https://github.com/toss/suspensive/pull/1161#issuecomment-2295241186 https://github.com/toss/suspensive/pull/1161 6 Co-authored-by: 2-NOW <[email protected]>
@codecov-commenter https://github.com/toss/suspensive/pull/1161#issuecomment-2256182766 1 Co-authored-by: codecov-commenter <[email protected]>
@SEOKKAMONI https://github.com/toss/suspensive/pull/1161#issuecomment-2267579703 1 Co-authored-by: SEOKKAMONI <[email protected]>

coauthors[bot] avatar Aug 15 '24 15:08 coauthors[bot]

  1. Merge origin/main please. we use [email protected] fixed by @gwansikk from now
  2. Share your proximate plan on this pull request please. I want to check what you have issue to do this after that date

manudeli avatar Aug 16 '24 04:08 manudeli

Share your proximate plan on this pull request please. I want to check what you have issue to do this after that date

I'll be doing some additional work this Sunday to make sure that the promise dehydratedState supported by v5 doesn't break v4's behavior. Once that's confirmed, the POC should be largely resolved. It's still an unfinished feature with no guaranteed implementation, but would it be okay to merge it into main ? @manudeli

2-NOW avatar Aug 16 '24 16:08 2-NOW

Share your proximate plan on this pull request please. I want to check what you have issue to do this after that date

would it be okay to merge it into main ? @manudeli

Sure, let's merge. to merge this branch, could you resolve conflict first please?

manudeli avatar Aug 17 '24 01:08 manudeli

Sure, let's merge. to merge this branch, could you resolve conflict first please?

I've resolved the conflict, please confirm that it's okay to merge. @manudeli

2-NOW avatar Aug 18 '24 11:08 2-NOW

Resolve knip error please

manudeli avatar Aug 18 '24 12:08 manudeli

Resolve knip error please

Fixed :D

2-NOW avatar Aug 18 '24 12:08 2-NOW