slash icon indicating copy to clipboard operation
slash copied to clipboard

fix(utils): fix mapValues type error

Open euijinkk opened this issue 2 years ago • 1 comments

Overview

I found mapValues function has two type Error. It's because

  1. T generic is not restricted. It is just unknown type. So I fixed it Record object type. But I'm not sure I should consider symbol type. First, I considered symbol, but I found slash team uses ObjectKeys which is for excluding symbol type. So I followed that. I wonder your opinion.
  2. Object.entries typing. I fixed it by assertion as slash team wrote in objectEntries.

PR Checklist

  • [x] I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

euijinkk avatar Oct 15 '22 10:10 euijinkk

Deploy Preview for slash-libraries ready!

Name Link
Latest commit 2c38878e37b476a77dae8d19e2af231974c3a2df
Latest deploy log https://app.netlify.com/sites/slash-libraries/deploys/6350ff8568cd560009672540
Deploy Preview https://deploy-preview-60--slash-libraries.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 15 '22 10:10 netlify[bot]

Thanks @euijinkk .

hoseungme avatar Oct 20 '22 08:10 hoseungme