slash
slash copied to clipboard
fix(utils): fix mapValues type error
Overview
I found mapValues
function has two type Error. It's because
- T generic is not restricted. It is just unknown type. So I fixed it Record object type. But I'm not sure I should consider symbol type. First, I considered symbol, but I found slash team uses
ObjectKeys
which is for excluding symbol type. So I followed that. I wonder your opinion. - Object.entries typing. I fixed it by
assertion
as slash team wrote inobjectEntries
.
PR Checklist
- [x] I read and included theses actions below
- I have read the Contributing Guide
- I have written documents and tests, if needed.
Deploy Preview for slash-libraries ready!
Name | Link |
---|---|
Latest commit | 2c38878e37b476a77dae8d19e2af231974c3a2df |
Latest deploy log | https://app.netlify.com/sites/slash-libraries/deploys/6350ff8568cd560009672540 |
Deploy Preview | https://deploy-preview-60--slash-libraries.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Thanks @euijinkk .