slash
slash copied to clipboard
feat: add tsup bundler
Overview
We need to change in bundler of libraries for consistency between library projects. tsup is easy to use, and is suitable to our conditions. Please check items below:
- more options for tsup config
- more deprecated packages in package.json
- more configs in package.json when it comes to publish
PR Checklist
- [ ] I read and included theses actions below
- I have read the Contributing Guide
- I have written documents and tests, if needed.
Deploy request for slash-libraries pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | 52ffae2af09d3290d5656f124f43f6def56f08b5 |
sorry for confusing. tsup will be replaced in favor of rollup
On Thu, Jul 27, 2023 at 18:27 Jonghyeon Ko @.***> wrote:
@.**** commented on this pull request.
In configs/tsup/package.json https://github.com/toss/slash/pull/314#discussion_r1276007177:
@@ -0,0 +1,12 @@ +{
- "name": @.***/tsup-config",
- "version": "0.1.0",
- "main": "./src/index.js",
- "types": "./src/index.d.ts",
- "devDependencies": {
- "tsup": "^7.1.0"
- },
- "publishConfig": {
How about defining tsup v7 as peerDependency of this package ⬇️ Suggested change
- "publishConfig": {
- "peerDependencies":{
- "tsup": "^7"
- },
- "publishConfig": {
— Reply to this email directly, view it on GitHub https://github.com/toss/slash/pull/314#pullrequestreview-1549418092, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA6JVLKBP7VBBWLERISD63XSIX7JANCNFSM6AAAAAA2X2MIQE . You are receiving this because you authored the thread.Message ID: @.***>
Closing since this pull request is stale. Please open the pull request again if possible.