es-toolkit icon indicating copy to clipboard operation
es-toolkit copied to clipboard

Support for groupBy

Open ehdrms785 opened this issue 1 year ago • 3 comments

Hello, @raon0211

It would be great if groupBy could be added to es-toolkit.

Could I try implementing this ?

Ex ) https://lodash.com/docs/4.17.15#groupBy

ehdrms785 avatar Aug 19 '24 03:08 ehdrms785

We actually already have groupBy in our library. Is this insufficient?

https://es-toolkit.slash.page/reference/array/groupBy.html#groupby

raon0211 avatar Aug 20 '24 12:08 raon0211

How to setup this project on windows? I am getting error at multiple stage

Vipul-Vermaa avatar Aug 20 '24 14:08 Vipul-Vermaa

We actually already have groupBy in our library. Is this insufficient?

https://es-toolkit.slash.page/reference/array/groupBy.html#groupby

Apologies, it was my mistake. I’m not sure why the groupBy method didn’t catch my eye when I was looking for it. I thought there might be some method for performance improvement, So I tried using a pure object.

Although I obtained some meaningful results, using a pure object—thus not utilizing the prototype—seems like a risky approach.

I’ll definitely participate again as a contributor if I have the opportunity in the future!

image

ehdrms785 avatar Aug 21 '24 07:08 ehdrms785

Thanks for giving attention to our project! Although the performance is a little lower than original lodash, our function has significantly slower bundle size. In addition, we will optimize our function in the future :)

raon0211 avatar Aug 22 '24 14:08 raon0211