serverless-glue icon indicating copy to clipboard operation
serverless-glue copied to clipboard

Argument deployment inconsistent between Jobs and Triggers.

Open jensuffhaus opened this issue 1 year ago • 0 comments

AWS Glue requires arguments to begin with "--".

It's a little wierd and AWS should do this behind the scenes, but it is what it is.

The plugin deploys a Job correctly and adds the "--" to the beginning of default arguments if they are not there in the yml already. This is great. "src/utils/cloud-formation.utils.ts:98-100"

However, triggers in glue can override these arguments and they also must begin with "--". Unfortunately, this plugin does not automatically check/prefix the argument for triggers the same way it does with the job itself. Developers can/must include the "--" in the yml. This is a little inconsistent and the same approach should be used for both. Either check and prepend or check and fail if they are missing. "src/utils/cloud-formation.utils.ts:120"

jensuffhaus avatar Jan 15 '24 10:01 jensuffhaus