linux icon indicating copy to clipboard operation
linux copied to clipboard

Fix typo 'acceptible'

Open TheTypoMaster opened this issue 9 years ago • 14 comments

TheTypoMaster avatar Sep 04 '15 14:09 TheTypoMaster

Username checks out

flarn2006 avatar Oct 10 '15 23:10 flarn2006

Indeed On Oct 10, 2015 7:27 PM, "flarn2006" [email protected] wrote:

Username checks out

— Reply to this email directly or view it on GitHub https://github.com/torvalds/linux/pull/203#issuecomment-147135497.

nkeck720 avatar Oct 11 '15 20:10 nkeck720

https://en.wiktionary.org/wiki/acceptible

sagarpanchal avatar Oct 12 '15 09:10 sagarpanchal

I don't see why every little spelling error in the commentary. Comments do not affect the compiled result, guys. If there is a spelling error in the code, by all means fix it, but please don't waste Linus' time with PRs about spelling mistakes that don't even help the kernel, other than maybe in the readability department. Spelling in the comments does not matter unless you absolutely cannot tell what is being said. On Oct 12, 2015 5:54 AM, "Sagar Panchal" [email protected] wrote:

https://en.wiktionary.org/wiki/acceptible

— Reply to this email directly or view it on GitHub https://github.com/torvalds/linux/pull/203#issuecomment-147354425.

nkeck720 avatar Oct 14 '15 11:10 nkeck720

Meant to say, "I don't see why you try to fix every little spelling error in the commentary." On Oct 14, 2015 7:14 AM, "Noah Keck" [email protected] wrote:

I don't see why every little spelling error in the commentary. Comments do not affect the compiled result, guys. If there is a spelling error in the code, by all means fix it, but please don't waste Linus' time with PRs about spelling mistakes that don't even help the kernel, other than maybe in the readability department. Spelling in the comments does not matter unless you absolutely cannot tell what is being said. On Oct 12, 2015 5:54 AM, "Sagar Panchal" [email protected] wrote:

https://en.wiktionary.org/wiki/acceptible

— Reply to this email directly or view it on GitHub https://github.com/torvalds/linux/pull/203#issuecomment-147354425.

nkeck720 avatar Oct 14 '15 11:10 nkeck720

@nkeck720 This is a bot :)

TheTypoMaster avatar Oct 14 '15 13:10 TheTypoMaster

I should add this: Hi! I'm a bot that checks GitHub for spelling mistakes, and I found one in your repository. When it should be 'acceptable', you typed 'acceptible'. I created this pull request to fix it!

If you think there is anything wrong with this pull request or just have a question, be kind to mail me at [email protected] (professional email, huh?). I’ll try to address the problem as soon as I’m aware of it.

Looking for the source code of this bot? Well, you have to be patient! The bot is under development and I will publish the source code as soon as I’m finished with it.

If you decide to close this pull request, pleace specify why before doing so.

With kind regards, TheTypoMaster

TheTypoMaster avatar Oct 14 '15 14:10 TheTypoMaster

@TheTypoMaster You have a typo ("pleace") in your comment here on github: "...pleace specify why before doing so"

petr0001 avatar Mar 04 '16 14:03 petr0001

@petr0001 Yep!

TheTypoMaster avatar Mar 23 '16 22:03 TheTypoMaster

Jesus christ people hate this bot

TheTypoMaster avatar Mar 23 '16 22:03 TheTypoMaster

What did I expect tbh

TheTypoMaster avatar Mar 23 '16 22:03 TheTypoMaster

I'm not gonna hate this bot but you are making a pulling request to the Linux kernel which is..

LuyangLi avatar Apr 06 '16 15:04 LuyangLi

The issue isn't your bot. The Linux project just does not accept Pull Requests on Github. There is a system for emailing patches to the Linux mailing list, search and you shall find.

ghost avatar Apr 06 '16 15:04 ghost

Maybe it would be a good idea for your bot to specifically blacklist Github repos which do not accept PR:s?

ghost avatar Apr 06 '16 15:04 ghost