torrust-tracker icon indicating copy to clipboard operation
torrust-tracker copied to clipboard

Add Timeouts to Tracker Client

Open da2ce7 opened this issue 1 year ago • 2 comments

closes: #677 closes: #682 closes: #681 closes: #679 closes: #680 closes: #678 closes: #683 closes: #676 closes: #767

part of epic:

  • #669

todo:

  • [ ] Write More Tests
  • [x] Do Code Review
  • [ ] Make Timeouts Configurable for the UDP client, like the Http Client.

done:

  • [x] https://github.com/torrust/torrust-tracker/issues/677
  • [x] https://github.com/torrust/torrust-tracker/issues/682
  • [x] https://github.com/torrust/torrust-tracker/issues/767
  • [x] https://github.com/torrust/torrust-tracker/issues/681
  • [x] https://github.com/torrust/torrust-tracker/issues/679
  • [x] https://github.com/torrust/torrust-tracker/issues/680
  • [x] https://github.com/torrust/torrust-tracker/issues/678
  • [x] https://github.com/torrust/torrust-tracker/issues/683
  • [x] https://github.com/torrust/torrust-tracker/issues/676

da2ce7 avatar Mar 28 '24 05:03 da2ce7

Codecov Report

Attention: Patch coverage is 53.52798% with 191 lines in your changes are missing coverage. Please review.

Project coverage is 80.08%. Comparing base (bf71687) to head (2a72445). Report is 2 commits behind head on develop.

Files Patch % Lines
src/shared/bit_torrent/tracker/udp/client.rs 65.00% 42 Missing :warning:
...bit_torrent/tracker/http/client/requests/scrape.rs 44.82% 16 Missing :warning:
src/shared/bit_torrent/tracker/udp/mod.rs 27.77% 13 Missing :warning:
src/console/clients/udp/mod.rs 0.00% 11 Missing :warning:
...t_torrent/tracker/http/client/requests/announce.rs 74.41% 11 Missing :warning:
src/console/clients/checker/checks/udp.rs 0.00% 9 Missing :warning:
src/console/clients/http/mod.rs 0.00% 9 Missing :warning:
...d/bit_torrent/tracker/http/client/responses/mod.rs 18.18% 9 Missing :warning:
src/console/clients/checker/app.rs 0.00% 8 Missing :warning:
src/console/clients/checker/checks/health.rs 0.00% 8 Missing :warning:
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #765      +/-   ##
===========================================
+ Coverage    77.71%   80.08%   +2.36%     
===========================================
  Files          158      162       +4     
  Lines         8711     8894     +183     
===========================================
+ Hits          6770     7123     +353     
+ Misses        1941     1771     -170     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 28 '24 05:03 codecov[bot]

@josecelano This Pull Request is Ready for Review, however it needs some polish before merging. :)

da2ce7 avatar Mar 30 '24 03:03 da2ce7

needs impossible rebase, closed by #923

da2ce7 avatar Jul 13 '24 08:07 da2ce7