mpv-progressbar
mpv-progressbar copied to clipboard
torque
Pause icon at the end
Any chance for a modification that removes the pause icon showing up at the end of a video? UX-wise I feel like pause says "the user has paused the video", rather than "the video has been paused". I have seen a decent chunk of videos that have no credits at the end, as soon as they end the pause icon appears and it takes me out of the movie too quick, plus it's kinda awkward.
I haven't noticed this happening, but there are a number of potential explanations. Either way, it's not caused intentionally—mpv likes to generate spurious "pause" events in a variety of situations. There's already a fair amount of logic to avoid the pause popup flickering in and out when frame stepping, but this is managed by hijacking the (default) keybindings, and is therefore pretty fragile.
This could probably be fixed by checking if the playback progress is at the end of the file (or possibly hooking one of the events launched at end-of-playback, if they are generated first) but I'm wondering if this is either tied to a specific mpv version or if it's something I have inadvertently already fixed in my development branch.
If it's about the MPV version, I believe it has happened ever since I started using the script months ago (maybe a year even). Is the development branch available to the public?
The development branch is this one: https://github.com/torque/mpv-progressbar/tree/enable-rework, but it is kind of stalled in the middle of a major refactoring, as I have been very busy for the last several months. It has some changes to the configuration handling and is currently missing a number of currently existing features (such as click-to-seek), so it's not ready for prime time.
I can give you a semi-functional build from it to test with, though looking at the code, I don't think the logic has changed. I wonder if the behavior is configuration-related (do you use a setting that keeps the window open when playback is finished?) as opposed to mpv-version-related. I've just quickly checked with both versions of my script, and I definitely don't see a pause icon at the end of playback.
Oh, yeah, should have mentioned it but I'm so used to it I forgot it's not default behavior. I've got keep-open=always on mpv.conf
I very much like that the pause icon is being displayed at the end of the video (with keep-open=always). Only frame seeking with custom bindings is annoying.
Ok, that's helpful. Thanks for chiming in as well, @FichteFoll, it's good to know there are some who appreciate this apparently accidental feature. I'll try to set aside some time this weekend to reproduce this and figure out an appropriate (optional) mitigation strategy.
Well I can see some would like it, so perhaps it should be left as a on/off setting. And yeah, it's also annoying that it appears when frame-by-frame seeking.