torbrowser-launcher icon indicating copy to clipboard operation
torbrowser-launcher copied to clipboard

Incorrect icon under Gnome Wayland session with MOZ_ENABLE_WAYLAND=1

Open arvidjaar opened this issue 2 years ago • 0 comments

Ubuntu 20.04 with Gnome desktop in Wayland mode Torbrowser launcher 0.3.2-9ubuntu1 Tor Browser 10.5.6

If I enable Firefox Wayland support with MOZ_ENABLE_WAYLAND=1, Tor Browser starts and shows full hardware acceleration in about:support but icon on task bar is default Firefox instead of expected Tor Browser. This is probably related to https://bugzilla.mozilla.org/show_bug.cgi?id=1607399 and workaround described there (add --name torbrowser parameter) works as well:

+++ ./start-tor-browser	2021-09-26 09:35:38.047547290 +0300
@@ -366,7 +366,7 @@ elif [ "$show_output" -eq 1 ]; then
     TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --class "Tor Browser" \
         -profile TorBrowser/Data/Browser/profile.default "${@}" < /dev/null
 else
-    TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --class "Tor Browser" \
+    TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --name torbrowser --class "Tor Browser" \
         -profile TorBrowser/Data/Browser/profile.default "${@}" > "$logfile" 2>&1 </dev/null
 fi
 

I wonder if it is acceptable for torbrowser-laucnher to edit start-tor-browser as a workaround?

arvidjaar avatar Sep 26 '21 06:09 arvidjaar