torbrowser-launcher icon indicating copy to clipboard operation
torbrowser-launcher copied to clipboard

Published 20 hours ago • verified publisher icon torproject

Add CLI mode

Open vrask opened this issue 5 years ago • 5 comments

Add option to download and install Tor Browser using CLI

Resolves #39

vrask avatar Aug 25 '20 04:08 vrask

Pinging @intrigeri to humbly request a review

vrask avatar Sep 02 '20 03:09 vrask

Hi,

Pinging @intrigeri to humbly request a review

Unfortunately, the only part of torbrowser-launcher that I'm knowledgeable enough about to do hopefully-proper reviews about is the AppArmor policy. I'm not familiar with the code base, so I'll pass.

intrigeri avatar Sep 02 '20 06:09 intrigeri

Hi,

Unfortunately, the only part of torbrowser-launcher that I'm knowledgeable enough about to do hopefully-proper reviews about is the AppArmor policy. I'm not familiar with the code base, so I'll pass.

Understood, saw you as the most active maintainer, but just read the .github/CODEOWNERS doc. Is @micahflee still active? If so, pinging to request a review (same humility level).

vrask avatar Sep 03 '20 04:09 vrask

@vrask Please kindly help to rebase to the latest. Thank you!

rogers0 avatar Oct 07 '20 12:10 rogers0

@vrask Please kindly help to rebase to the latest. Thank you!

No problem :)

Added the updates for socks5h to launcher_cli.py as well. I didn't see an easy way to do CLI mode in launcher.py, would it be better long-term to implement in that file? If so, I can work on it over the next week or two.

vrask avatar Oct 21 '20 20:10 vrask