tor
tor copied to clipboard
torproject
config: Catch missing Bridge for ClientTransportPlugin
First of all, tor doesn't support multiple transport name on a single *TransportPlugin line so get rid of that. The manpage has never documented that feature and it complexifies the line for no reason. A user can just use multiple ClientTransportPlugin line instead.
Second, if no Bridge line is found, error immediately and exit. Don't leave the Bridge line alone there leading to bugs like #25528
Third, when making sure we have a Bridge line with a ClientTransportPlugin, we now check at the managed proxy list. In order to pull this off, the transport name had to be added to the managed_proxy_t object so we can match for which transport it is used for. And thus justifying the removal of multiple transport support which adds no benefit except complexity.
Fixes #40106
Signed-off-by: David Goulet [email protected]
Pull Request Test Coverage Report for Build 10414
- 19 of 30 (63.33%) changed or added relevant lines in 2 files are covered.
- 2 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-0.009%) to 64.501%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/app/config/config.c | 13 | 14 | 92.86% |
| src/feature/client/transports.c | 6 | 16 | 37.5% |
| <!-- | Total: | 19 | 30 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| src/app/config/config.c | 1 | 79.5% |
| src/feature/client/transports.c | 1 | 50.96% |
| <!-- | Total: | 2 |
| Totals | |
|---|---|
| Change from base Build 10407: | -0.009% |
| Covered Lines: | 51926 |
| Relevant Lines: | 80504 |
