tor
tor copied to clipboard
torproject
hs: Don't overwrite DoS parameters on circuit with consensus params
Turns out that the HS DoS defenses parameters were overwritten by the consensus parameters everytime a new consensus would arrive.
This means that a service operator can still enable the defenses but as soon as the intro point relay would get a new consensus, they would be overwritten. And at this commit, the network is entirely disabling DoS defenses.
Fix this by introducing an "explicit" flag that indicate if the ESTABLISH_INTRO cell DoS extension set those parameters or not. If set, avoid using the consenus at once.
We are not bumping the protover HSIntro value for this because 0.4.2.x series is EOL in 1 month and thus 0.4.3.x would be the only series with this bug. We are confident that a backport and then upgrade path to the latest 0.4.4.x stable coming up soon is enough to mitigate this problem in the coming months.
It avoids the upgrade path on the service side by keeping the requirement for protover HSIntro=5.
Fixes #40109
Signed-off-by: David Goulet [email protected]
Pull Request Test Coverage Report for Build 9937
- 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.001%) to 63.686%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/feature/hs/hs_dos.c | 0 | 2 | 0.0% |
| <!-- | Total: | 1 | 3 |
| Totals | |
|---|---|
| Change from base Build 9910: | -0.001% |
| Covered Lines: | 50274 |
| Relevant Lines: | 78941 |
