tor
tor copied to clipboard
Published
20 hours ago •
torproject
torproject
fix for circpad_add_matching_machines to be able to negotiate more machines
As part of circuitpadding.c, in circpad_add_matching_machines(), the macros FOR_EACH_CIRCUIT_MACHINE_BEGIN and SMARTLIST_FOREACH_REVERSE_BEGIN currently expand to a for loop each. The outer loop goes over each machine index (currently 2, set by CIRCPAD_MAX_MACHINES), while the inner loop looks for a suitable machine for that index to negotiate. As soon as one is found and negotiated, currently, the function returns without looking for a machine for later indices in the outer loop. The fix replaces the return with a break of the inner loop, enabling the function to negotiate machines for later indices by continuing the outer loop.
Pull Request Test Coverage Report for Build 5542
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 62.627%
| Totals | |
|---|---|
| Change from base Build 5510: | 0.0% |
| Covered Lines: | 46923 |
| Relevant Lines: | 74925 |
