stem icon indicating copy to clipboard operation
stem copied to clipboard

for issue #116

Open 0-harshit-0 opened this issue 2 years ago • 3 comments

added functionality to connect using URL

0-harshit-0 avatar Jun 19 '22 11:06 0-harshit-0

Hi harshit, sorry for the long delay. This is a fine attempt but has some issues...

  1. It breaks both method's pydocs. The first comment block of a method is special in that Sphinx uses it to generate API documentation.
  2. Rather than allowing hostnames for the address argument it would be better if we added a new 'hostname' argument. This way the argument isn't a misnomer and can't accidently trigger a DNS lookup (which could leak data in some environments).
  3. This change would require unit and integ test coverage.

atagar avatar Jun 27 '22 22:06 atagar

oh ok got it.

0-harshit-0 avatar Jun 27 '22 22:06 0-harshit-0

hello, I have made a new commit to this pull request.

0-harshit-0 avatar Jun 28 '22 08:06 0-harshit-0

It's been a while without tests being added so closing.

atagar avatar Sep 27 '22 19:09 atagar