tornado icon indicating copy to clipboard operation
tornado copied to clipboard

BLD: prefer to use bdist_wheel from setuptools rather than wheel

Open tacaswell opened this issue 1 year ago • 1 comments

Due to upcoming changes to setuptools (https://github.com/pypa/setuptools/pull/4647) using bdist_wheel from wheel will fail.

This could possibly be simplified to always use wheel from setuptools, however I am unsure on your policy on the range of setuptool versions supported.

tacaswell avatar Oct 11 '24 01:10 tacaswell

I'm also unsure of my policy for setuptools versions; I've never really had to think about it. Now that we can put a version in the build-system section of pyproject.toml there's no real reason to support older versions of setuptools, is there?

I'd love to get rid of this whole bdist_wheel override, and it looks like it might be possible with current versions of setuptools. I haven't tested this PR (on the repo that I copied the bdist_wheel override from), but it looks like setuptools now has better understanding of abi3. https://github.com/joerick/python-abi3-package-sample/pull/30/files

bdarnell avatar Oct 11 '24 13:10 bdarnell

In https://github.com/tornadoweb/tornado/pull/3433 I've removed the bdist_wheel override entirely after verifying that it doesn't break anything.

bdarnell avatar Oct 24 '24 14:10 bdarnell