tornado icon indicating copy to clipboard operation
tornado copied to clipboard

Test fail with openssl 3.2

Open danigm opened this issue 1 year ago • 1 comments

One test is failing when running the test suite in openSUSE Tumbleweed with openssl 3.2:

FAIL: test_error_logging (tornado.test.simple_httpclient_test.SimpleHTTPSClientTestCase.test_error_logging)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/abuild/rpmbuild/BUILD/tornado-6.4/tornado/testing.py", line 102, in __call__
    result = self.orig_method(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/abuild/rpmbuild/BUILD/tornado-6.4/tornado/test/simple_httpclient_test.py", line 573, in test_error_logging
    self.assertFalse(expect_log.logged_stack)
AssertionError: True is not false

Looks like the new openssl returns a different error code in this case when the certification is not valid and instead of returning ssl.SSL_ERROR_SSL it's returning ssl.SSL_ERROR_SYSCALL, in the iostream.py

danigm avatar Jan 11 '24 13:01 danigm

The unhandled error appears to to break fetching for downstreams (https://github.com/jupyterlab/jupyterlab/issues/15602).

krassowski avatar Jan 12 '24 12:01 krassowski