tornado icon indicating copy to clipboard operation
tornado copied to clipboard

Patch to compile on gnu/hurd

Open SnarkBoojum opened this issue 2 years ago • 1 comments

The Debian package for tornado has to following patch since long, but I think it was never forwarded:

--- python-tornado.orig/tornado/test/httpserver_test.py
+++ python-tornado/tornado/test/httpserver_test.py
@@ -711,6 +711,8 @@
     not hasattr(socket, "AF_UNIX") or sys.platform == "cygwin",
     "unix sockets not supported on this platform",
 )
[email protected](sys.platform == 'gnu0',
+                 "unix sockets with SO_REUSEADDR not supported on this platform")
 class UnixSocketTest(AsyncTestCase):
     """HTTPServers can listen on Unix sockets too.

you might be interested.

SnarkBoojum avatar Jun 26 '23 05:06 SnarkBoojum

I think that patch may be obsolete. We now have an except clause in bind_unix_socket to catch an error that is said to occur on hurd:

https://github.com/tornadoweb/tornado/blob/559f94aa8809fa37cb2015fadc06d8e46430fafe/tornado/netutil.py#L205-L210

bdarnell avatar Jul 15 '23 23:07 bdarnell