barely_json icon indicating copy to clipboard operation
barely_json copied to clipboard

Published 20 hours ago • verified publisher icon torfsen

Made a separate grammar and illegal value file

Open tusharmakkar08 opened this issue 7 years ago • 2 comments

Hey @torfsen

As discussed I have moved out grammar to a separate file. Also I have moved IllegalValue out to prevent circular dependency.

Thanks.

tusharmakkar08 avatar May 28 '17 13:05 tusharmakkar08

Hey @torfsen

Any updates on this ?

Thanks

tusharmakkar08 avatar Jul 16 '17 08:07 tusharmakkar08

Any updates on this?

tusharmakkar08 avatar Apr 21 '18 12:04 tusharmakkar08

Sorry for the (very) late reply, but given that there are only ~200 LOC I feel that splitting it up into 3 modules overcomplicates things. So I'm not going to merge this, but thank you nevertheless! For future contributions, it's always a good idea to do a quick coordination (e.g. via an issue) before spending too much work on something that won't get merged.

torfsen avatar Jul 29 '23 12:07 torfsen