OSM2World icon indicating copy to clipboard operation
OSM2World copied to clipboard

Elevations in feet are ignored

Open 1ec5 opened this issue 1 year ago • 1 comments

If ele is expressed in feet using the usual units, it looks like the tag is dropped because it isn’t an integer or floating point number. (I’m only doing code inspection, so I could be wrong about this.)

ele is actually documented to be only in meters, but it is tagged in feet pretty commonly in practice, and this proposal would formalize that practice. Regardless, I just wanted to make sure you were aware that ele was being parsed this way, in case it was merely an oversight, since OSM2World does have code to parse other tags with support for units. If this is intentional and you believe ele should not contain units, I would welcome your feedback on the proposal’s talk page. Thanks!

https://github.com/tordanik/OSM2World/blob/aade8c5f6a7dc475a448f5f9a6263d2fe9a8481e/src/main/java/org/osm2world/core/map_elevation/creation/EleTagElevationCalculator.java#L15 https://github.com/tordanik/OSM2World/blob/aade8c5f6a7dc475a448f5f9a6263d2fe9a8481e/src/main/java/org/osm2world/core/util/ValueParseUtil.java#L66-L71

1ec5 avatar Jul 01 '23 18:07 1ec5

Hi, thank you for making me aware of this proposal. For OSM2World, different units for elevation values are not a problem as long as these units are explicit and well-defined. (Different standards for what elevation 0 means are a problem, as are incorrect elevation values even if they're signposted "on the ground" – but that's not directly affected by this proposal either way.)

If the proposal is approved, I have no problem with updating OSM2World to use the same value parsing logic which already exists for keys such as height.

tordanik avatar Jul 04 '23 22:07 tordanik