django-libsass icon indicating copy to clipboard operation
django-libsass copied to clipboard

Add tests files in MANIFEST

Open joelcapitao opened this issue 1 year ago • 4 comments

Those files are required for distribution packaging, as we need to run the tests during the package build.

joelcapitao avatar Nov 18 '24 10:11 joelcapitao

Thanks @jcapiitao! A potential issue here is that someone installing the source package will end up with a tests module at the top level of their site-packages. Do we need to perhaps consider moving this into a submodule of django_libsass (and then potentially adjusting the config so that django_libsass.tests is included in the source package but not the wheel)?

gasman avatar Nov 19 '24 12:11 gasman

Oh right, we need to move core content and tests into django_libsass directory. We can also include tests only in sdist and not wheel, do you want me to work on that in this PR ? or should I open new one ?

joelcapitao avatar Nov 19 '24 13:11 joelcapitao

Yes please - having those updates as part of this PR makes most sense, I think.

gasman avatar Nov 19 '24 14:11 gasman

With latest commit, we have tests/ folder in source distribution but not the wheel. And top level is django_libsass with just the content in __init__.py.

ls -l .venv/lib/python3.12/site-packages/django_libsass
__init__.py
__pycache__
less dist/django-libsass-0.9.tar.gz
django-libsass-0.9/LICENSE
django-libsass-0.9/MANIFEST.in
django-libsass-0.9/PKG-INFO
django-libsass-0.9/README.rst
django-libsass-0.9/django_libsass/
django-libsass-0.9/runtests.py
django-libsass-0.9/setup.cfg
django-libsass-0.9/setup.py
django-libsass-0.9/tests/
django-libsass-0.9/tox.ini

joelcapitao avatar Dec 01 '24 19:12 joelcapitao