buckup
buckup copied to clipboard
Use deny policies rather than conditions to reject insecure access
There were some issues with the previous format, where the condition would be applied strangely and somewhat selectively. I couldn't reproduce them, but doing the policies this way is probably better.
This uses explicit "Deny" policies, which should be easier to understand, since they're applied before any other policies, making them simpler to manage.
Policies taken from https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/blob/f90d8a385e4c70afd048e8997dcccf125b362236/main.tf#L965 and https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/blob/f90d8a385e4c70afd048e8997dcccf125b362236/main.tf#L934