Testsuite, works.

[cheako]

I'm not sure why tor2web exits, it could be that it doesn't like the self signed cert.

[cheako]

The C version works as an echo server, a milestone past the Python version. https://travis-ci.org/cheako/tor2web/builds/274155883#L935

[cheako]

It's important to get this working so that behavior with the C implementation can easily be compared. This will direct development, ensuring the work being done is done correctly. Currently the C code is being written against my best guess.

I'd like to have more awareness about what Tor2web actually does.

[NSkelsey]

Hey @cheako, from my understanding of the Tor2Web codebase there are no unittests written for the project. The best you can do to interpret proper functionality is run a tor2web node and examine the results.

With that said, I think that putting together a set of curl tests against the implementation would be super helpful. python requests would also be a great resource for unittest tor2web functionality

[cheako]

@NSkelsey In trying to run a tor2web instance but it exits prior to fielding any requests, there is no indication as to why. Instead of doing things by hand I wrote, or rather reused, a script for doing this. This way testing can easily be repeated, by anyone.

Please try and identify why this script fails to start tor2web while running on travis.ci, or let me know if it does start and link to your test output.

[codecov-io]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a325583). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #339   +/-   ##
=========================================
  Coverage          ?   57.17%           
=========================================
  Files             ?       15           
  Lines             ?     2669           
  Branches          ?        0           
=========================================
  Hits              ?     1526           
  Misses            ?     1143           
  Partials          ?        0

Impacted Files	Coverage Δ
tor2web/t2w.py	60.33% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a325583...cdd4823. Read the comment docs.