Tor2web icon indicating copy to clipboard operation
Tor2web copied to clipboard

added support for more HTTP response headers

Open virgil opened this issue 9 years ago • 9 comments

For example, the "Link" and "X-Pingback" headers on: http://54ogum7gwxhtgiya.onion

This patch makes those headers (and others) work as intended.

virgil avatar Mar 09 '15 11:03 virgil

Correction, URL is: http://54ogum7gwxhtgiya.onion/blog/index.php/welcome-home/

virgil avatar Mar 13 '15 08:03 virgil

Code Health Code quality remained the same when pulling 34fede7 on virgil:patch-38 into 52c7249 on globaleaks:master.

landscape-bot avatar May 07 '15 22:05 landscape-bot

Code Health Code quality remained the same when pulling 34fede7 on virgil:patch-38 into 52c7249 on globaleaks:master.

landscape-bot avatar May 07 '15 22:05 landscape-bot

Code Health Repository health decreased by 11% when pulling 34fede7 on virgil:patch-38 into 24bbce7 on globaleaks:master.

landscape-bot avatar May 08 '15 09:05 landscape-bot

Code Health Repository health decreased by 12% when pulling 34fede7 on virgil:patch-38 into c99a6a9 on globaleaks:master.

landscape-bot avatar May 09 '15 22:05 landscape-bot

Code Health Repository health decreased by 17% when pulling 34fede7 on virgil:patch-38 into 85e0f4e on globaleaks:master.

landscape-bot avatar May 09 '15 22:05 landscape-bot

Still think this patch is a good idea. Make more edge cases work. And making edge cases work is nice.

virgil avatar Jul 09 '16 15:07 virgil

@virgil could you please clarify me the patch?

this way i can validate it and integrate in a release

evilaliv3 avatar Jul 09 '16 20:07 evilaliv3

The important lines are 1087 and 1088. In short, they say, "If we encounter a header we don't recognize, go ahead and do regex URL replacement on it."

I'm presuming that in general if you a .onion URL in a header, it should, by default, be rewritten.

virgil avatar Jul 09 '16 21:07 virgil