picasso icon indicating copy to clipboard operation
picasso copied to clipboard

[FX-5183] Add Collapse transition

Open mkrl opened this issue 1 year ago • 2 comments

FX-5183

Description

Adds a new Collapse transition to be used instead of the MUI 4 counterpart

How to test

  • Temploy
  • Check the code and a new story in Storybook

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

All development checks should be done and set checked to pass the GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

mkrl avatar May 06 '24 22:05 mkrl

🦋 Changeset detected

Latest commit: 5cdfac34b5f63ee2da791d196742c86157a14a00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso-collapse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 06 '24 22:05 changeset-bot[bot]

:warning: Following packages are missing changesets. Please check if they don't require one.

@toptal/picasso-fade

toptal-devbot avatar May 06 '24 22:05 toptal-devbot