[FX-5183] Add Collapse transition
Description
Adds a new Collapse transition to be used instead of the MUI 4 counterpart
How to test
- Temploy
- Check the code and a new story in Storybook
Screenshots
| Before. | After. |
|---|---|
| Insert screenshots or screen recordings | Insert screenshots or screen recordings |
Development checks
- [x] Add changeset according to guidelines (if needed)
- [x] Read CONTRIBUTING.md and Component API principles
- [x] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
- [x] Annotate all
propsin component with documentation - [x] Create
examplesfor component - [x] Ensure that deployed demo has expected results and good examples
- [x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
- [x] Self reviewed
- [x] Covered with tests (visual tests included)
All development checks should be done and set checked to pass the GitHub Bot: TODOLess action
PR commands
List of available commands:
-
@toptal-bot run package:alpha-release- Release alpha version -
@toptal-anvil ping reviewers- Ping FX team for review
PR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
- You have no extra requests.
- You have optional requests.
- Add
nit:to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle)
- Add
When to request changes? ❌
You are not OK with merging this PR because
- Something is broken after the changes.
- Acceptance criteria is not reached.
- Code is dirty.
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
- There are leftovers like unnecessary logs, comments, etc.
- You have an opinionated comment regarding the code that requires a discussion.
- You have questions.
How to handle the comments?
- An owner of a comment is the only one who can resolve it.
- An owner of a comment must resolve it when it's addressed.
- A PR owner must reply with ✅ when a comment is addressed.
🦋 Changeset detected
Latest commit: 5cdfac34b5f63ee2da791d196742c86157a14a00
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @toptal/picasso-collapse | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
:warning: Following packages are missing changesets. Please check if they don't require one.
@toptal/picasso-fade