keycodes icon indicating copy to clipboard operation
keycodes copied to clipboard

Published 20 hours ago • verified publisher icon toptal

The Delete button does not have a description

Open EntityPlantt opened this issue 2 years ago • 5 comments

image

The Delete button does not have a description.

EntityPlantt avatar Jan 28 '23 10:01 EntityPlantt

Hi @EntityPlantt, thanks for taking the time to open this issue! Feel free to open a PR with your suggestions!

konstrybakov avatar Jan 30 '23 07:01 konstrybakov

I think this is a bug @konstrybakov - the delete key has a description but isn't being displayed: https://github.com/toptal/keycodes/blob/main/lib/keycodes/with-events.ts#L340

Same goes for the keys, PageUp, PageDown, End, Home, NumPad Equals, and probably a few more.

wesbos avatar Jan 30 '23 13:01 wesbos

Hey, @EntityPlantt, thank you for bringing this to our attention. I've marked this as a bug and we will place it in our backlog. However, even though it is a bug, we are open to contributions!

This 👇 shows the description though, so something is definitely wrong https://www.toptal.com/developers/keycode/delete

Some strange behavior there 🪄

konstrybakov avatar Feb 01 '23 14:02 konstrybakov

Thanks for looking into the bug.

EntityPlantt avatar Feb 01 '23 16:02 EntityPlantt

I fixed it https://github.com/toptal/keycodes/pull/338

wesbos avatar Feb 01 '23 17:02 wesbos