topos icon indicating copy to clipboard operation
topos copied to clipboard

feat: update cargo files to use workspace package

Open Freyskeyd opened this issue 1 year ago • 6 comments
trafficstars

Description

This PR updates Cargo.toml files to use workspace value instead of redefining the same value in each crate.

PR Checklist:

  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added or updated tests that comprehensively prove my change is effective or that my feature works

Freyskeyd avatar Jan 16 '24 13:01 Freyskeyd

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8fb4003) 66.95% compared to head (e0fadef) 68.99%. Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   66.95%   68.99%   +2.03%     
==========================================
  Files         220      220              
  Lines       12109    12109              
==========================================
+ Hits         8107     8354     +247     
+ Misses       4002     3755     -247     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 16 '24 14:01 codecov[bot]

cargo-readme isn't compatible yet with workspace inheritance...

Freyskeyd avatar Jan 16 '24 14:01 Freyskeyd

Hmm, why is CI trying to parse the README as toml? @Freyskeyd

dvdplm avatar Jan 16 '24 15:01 dvdplm

Hmm, why is CI trying to parse the README as toml? @Freyskeyd

it is part of how cargo-readme works, it reads the Cargo.toml to extract relevant data

Freyskeyd avatar Jan 16 '24 16:01 Freyskeyd

@Freyskeyd Can we move this PR to draft status while waiting for cargo-readme to fix the issue?

dvdplm avatar Jan 23 '24 11:01 dvdplm

@Freyskeyd Is cargo-readme fixed now you reckon?

dvdplm avatar Feb 21 '24 09:02 dvdplm