ttk icon indicating copy to clipboard operation
ttk copied to clipboard

Can 64-bit option rely on VTK for consistency?

Open jspanchu opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. It is strange when we intermix code that uses vtk filters and ttk filters. Some assumptions on the 'id' data type can no longer be safe. (int vs long long, ttk::SimplexId vs vtkIdType)

Describe the solution you'd like It would be nice if ttk::SimplexId and vtkIdType were consistent when TTK is built with ParaView/VTK support. The cmake config script can check to see if VTK was built with support for 64-bit id type. If it were the case, then we turn on TTK_ENABLE_64_BIT_IDS. By default, this option is turned off config.cmake:98

jspanchu avatar Feb 19 '22 07:02 jspanchu

This seems reasonable to me. +1

JonasLukasczyk avatar Feb 22 '22 13:02 JonasLukasczyk

in principle, that makes sense. two things:

  • we first need to carefully check that all our tests indeed work as expected when switching to 64 bits
  • we need to assess the performance loss induced by the 64 bit comparisons (instead of 32 bit comparisons) and there WILL be some.

julien-tierny avatar Feb 25 '22 09:02 julien-tierny

Fair enough. Let me know if there is anything I can do to help!

jspanchu avatar Apr 17 '22 21:04 jspanchu